mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v2] ASoC: atmel: mchp-pdmc: Remove unnecessary print function dev_err()
@ 2022-03-10  8:27 Jiapeng Chong
  2022-03-10 13:13 ` Mark Brown
  0 siblings, 1 reply; 2+ messages in thread
From: Jiapeng Chong @ 2022-03-10  8:27 UTC (permalink / raw)
  To: codrin.ciubotariu
  Cc: lgirdwood, broonie, perex, tiwai, nicolas.ferre,
	alexandre.belloni, claudiu.beznea, alsa-devel, linux-arm-kernel,
	linux-kernel, Jiapeng Chong, Abaci Robot

The print function dev_err() is redundant because
platform_get_irq() already prints an error.

Eliminate the follow coccicheck warning:

./sound/soc/atmel/mchp-pdmc.c:991:2-9: line 991 is redundant because
platform_get_irq() already prints an error.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Reviewed-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
---
Changes in v2:
  -The braces be removed.

 sound/soc/atmel/mchp-pdmc.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/sound/soc/atmel/mchp-pdmc.c b/sound/soc/atmel/mchp-pdmc.c
index c44636f6207d..7b737e3f67b7 100644
--- a/sound/soc/atmel/mchp-pdmc.c
+++ b/sound/soc/atmel/mchp-pdmc.c
@@ -987,10 +987,8 @@ static int mchp_pdmc_probe(struct platform_device *pdev)
 		return ret;
 
 	irq = platform_get_irq(pdev, 0);
-	if (irq < 0) {
-		dev_err(dev, "failed to get irq: %d\n", irq);
+	if (irq < 0)
 		return irq;
-	}
 
 	dd->pclk = devm_clk_get(dev, "pclk");
 	if (IS_ERR(dd->pclk)) {
-- 
2.20.1.7.g153144c


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-03-10 13:13 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-10  8:27 [PATCH v2] ASoC: atmel: mchp-pdmc: Remove unnecessary print function dev_err() Jiapeng Chong
2022-03-10 13:13 ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®