From: Kalle Valo <kvalo@kernel.org>
To: Colin Ian King <colin.i.king@gmail.com>
Cc: "Rafał Miłecki" <zajec5@gmail.com>,
linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bcma: gpio: remove redundant re-assignment of chip->owner
Date: Thu, 10 Mar 2022 16:18:11 +0000 (UTC) [thread overview]
Message-ID: <164692908978.6056.13110647210803354793.kvalo@kernel.org> (raw)
In-Reply-To: <20220303085841.1124766-1-colin.i.king@gmail.com>
Colin Ian King <colin.i.king@gmail.com> wrote:
> There are two identical assignments of chip->owner to the same value,
> the second assignment is redundant and can be removed.
>
> Cleans up cppcheck warning:
> drivers/bcma/driver_gpio.c:184:15: style: Variable 'chip->owner' is
> reassigned a value before the old one has been used. [redundantAssignment]
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Patch applied to wireless-next.git, thanks.
857f837d856a bcma: gpio: remove redundant re-assignment of chip->owner
--
https://patchwork.kernel.org/project/linux-wireless/patch/20220303085841.1124766-1-colin.i.king@gmail.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2022-03-10 16:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-03 8:58 Colin Ian King
2022-03-10 16:18 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=164692908978.6056.13110647210803354793.kvalo@kernel.org \
--to=kvalo@kernel.org \
--cc=colin.i.king@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®