[PATCH] bcma: gpio: remove redundant re-assignment of chip->owner

[PATCH] bcma: gpio: remove redundant re-assignment of chip->owner

[Colin Ian King]

There are two identical assignments of chip->owner to the same value,
the second assignment is redundant and can be removed.

Cleans up cppcheck warning:
drivers/bcma/driver_gpio.c:184:15: style: Variable 'chip->owner' is
reassigned a value before the old one has been used. [redundantAssignment]

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
 drivers/bcma/driver_gpio.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/bcma/driver_gpio.c b/drivers/bcma/driver_gpio.c
index 8a1e4705bc87..1e74ec1c7f23 100644
--- a/drivers/bcma/driver_gpio.c
+++ b/drivers/bcma/driver_gpio.c
@@ -181,7 +181,6 @@ int bcma_gpio_init(struct bcma_drv_cc *cc)
 	chip->set		= bcma_gpio_set_value;
 	chip->direction_input	= bcma_gpio_direction_input;
 	chip->direction_output	= bcma_gpio_direction_output;
-	chip->owner		= THIS_MODULE;
 	chip->parent		= bus->dev;
 #if IS_BUILTIN(CONFIG_OF)
 	chip->of_node		= cc->core->dev.of_node;
-- 
2.34.1

Re: [PATCH] bcma: gpio: remove redundant re-assignment of chip->owner

[Kalle Valo]

Colin Ian King <colin.i.king@gmail.com> wrote:

> There are two identical assignments of chip->owner to the same value,
> the second assignment is redundant and can be removed.
> 
> Cleans up cppcheck warning:
> drivers/bcma/driver_gpio.c:184:15: style: Variable 'chip->owner' is
> reassigned a value before the old one has been used. [redundantAssignment]
> 
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>

Patch applied to wireless-next.git, thanks.

857f837d856a bcma: gpio: remove redundant re-assignment of chip->owner

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20220303085841.1124766-1-colin.i.king@gmail.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches