* [PATCH RESEND V2] extcon: usb-gpio: Remove disable irq operation in system sleep.
@ 2022-03-11 6:45 Bruce Chen
0 siblings, 0 replies; 2+ messages in thread
From: Bruce Chen @ 2022-03-11 6:45 UTC (permalink / raw)
To: bruce.chen, rogerq, myungjoo.ham, cw00.choi, linux-kernel
Cc: orsonzhai, gengcixi, baolin.wang7, zhang.lyra
From: Bruce Chen <bruce.chen@unisoc.com>
If disable vbus/id irq, it will lead to wakeup system fail
in unisoc platform. In unisoc platform, Irq enable and irq
wakeup are the same interrupt line. So remove disable vbus/id
irq operation is a way to solve the issue.
Signed-off-by: Bruce Chen <bruce.chen@unisoc.com>
Acked-by: Roger Quadros <rogerq@kernel.org>
---
drivers/extcon/extcon-usb-gpio.c | 15 ---------------
1 file changed, 15 deletions(-)
diff --git a/drivers/extcon/extcon-usb-gpio.c b/drivers/extcon/extcon-usb-gpio.c
index f2b65d9..40d967a 100644
--- a/drivers/extcon/extcon-usb-gpio.c
+++ b/drivers/extcon/extcon-usb-gpio.c
@@ -226,16 +226,6 @@ static int usb_extcon_suspend(struct device *dev)
}
}
- /*
- * We don't want to process any IRQs after this point
- * as GPIOs used behind I2C subsystem might not be
- * accessible until resume completes. So disable IRQ.
- */
- if (info->id_gpiod)
- disable_irq(info->id_irq);
- if (info->vbus_gpiod)
- disable_irq(info->vbus_irq);
-
if (!device_may_wakeup(dev))
pinctrl_pm_select_sleep_state(dev);
@@ -267,11 +257,6 @@ static int usb_extcon_resume(struct device *dev)
}
}
- if (info->id_gpiod)
- enable_irq(info->id_irq);
- if (info->vbus_gpiod)
- enable_irq(info->vbus_irq);
-
queue_delayed_work(system_power_efficient_wq,
&info->wq_detcable, 0);
--
1.9.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH RESEND V2] extcon: usb-gpio: Remove disable irq operation in system sleep.
@ 2022-03-11 6:42 Bruce Chen
0 siblings, 0 replies; 2+ messages in thread
From: Bruce Chen @ 2022-03-11 6:42 UTC (permalink / raw)
To: bruce.chen, rogerq, myungjoo.ham, cw00.choi, linux-kernel
Cc: orsonzhai, gengcixi, baolin.wang7, zhang.lyra
From: Bruce Chen <bruce.chen@unisoc.com>
If disable vbus/id irq, it will lead to wakeup system fail
in unisoc platform. In unisoc platform, Irq enable and irq
wakeup are the same interrupt line. So remove disable vbus/id
irq operation is a way to solve the issue.
Signed-off-by: Bruce Chen <bruce.chen@unisoc.com>
Acked-by: Roger Quadros <rogerq@kernel.org>
---
drivers/extcon/extcon-usb-gpio.c | 15 ---------------
1 file changed, 15 deletions(-)
diff --git a/drivers/extcon/extcon-usb-gpio.c b/drivers/extcon/extcon-usb-gpio.c
index f2b65d9..40d967a 100644
--- a/drivers/extcon/extcon-usb-gpio.c
+++ b/drivers/extcon/extcon-usb-gpio.c
@@ -226,16 +226,6 @@ static int usb_extcon_suspend(struct device *dev)
}
}
- /*
- * We don't want to process any IRQs after this point
- * as GPIOs used behind I2C subsystem might not be
- * accessible until resume completes. So disable IRQ.
- */
- if (info->id_gpiod)
- disable_irq(info->id_irq);
- if (info->vbus_gpiod)
- disable_irq(info->vbus_irq);
-
if (!device_may_wakeup(dev))
pinctrl_pm_select_sleep_state(dev);
@@ -267,11 +257,6 @@ static int usb_extcon_resume(struct device *dev)
}
}
- if (info->id_gpiod)
- enable_irq(info->id_irq);
- if (info->vbus_gpiod)
- enable_irq(info->vbus_irq);
-
queue_delayed_work(system_power_efficient_wq,
&info->wq_detcable, 0);
--
1.9.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-11 6:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-11 6:45 [PATCH RESEND V2] extcon: usb-gpio: Remove disable irq operation in system sleep Bruce Chen
-- strict thread matches above, loose matches on Subject: below --
2022-03-11 6:42 Bruce Chen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®