From: Jens Axboe <axboe@kernel.dk>
To: Tejun Heo <tj@kernel.org>
Cc: Josef Bacik <josef@toxicpanda.com>,
linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
kernel-team@fb.com
Subject: Re: [PATCH v3 for-5.18/block] block: don't merge across cgroup boundaries if blkcg is enabled
Date: Mon, 14 Mar 2022 19:15:06 -0600 [thread overview]
Message-ID: <164730690621.219116.11184082869298025827.b4-ty@kernel.dk> (raw)
In-Reply-To: <Yi/eE/6zFNyWJ+qd@slm.duckdns.org>
On Mon, 14 Mar 2022 14:30:11 -1000, Tejun Heo wrote:
> blk-iocost and iolatency are cgroup aware rq-qos policies but they didn't
> disable merges across different cgroups. This obviously can lead to
> accounting and control errors but more importantly to priority inversions -
> e.g. an IO which belongs to a higher priority cgroup or IO class may end up
> getting throttled incorrectly because it gets merged to an IO issued from a
> low priority cgroup.
>
> [...]
Applied, thanks!
[1/1] block: don't merge across cgroup boundaries if blkcg is enabled
commit: 6b2b04590b51aa4cf395fcd185ce439cab5961dc
Best regards,
--
Jens Axboe
prev parent reply other threads:[~2022-03-15 1:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Yi71WZ3O9/YViHSb@slm.duckdns.org>
[not found] ` <107965ce-a29a-b5f4-ef87-63b753380891@kernel.dk>
2022-03-14 20:41 ` [PATCH block-5.17] block: don't merge across cgroup boundaries if iocost or iolatency is active Tejun Heo
2022-03-14 23:50 ` [PATCH v2 for-5.18/block] block: don't merge across cgroup boundaries if blkcg is enabled Tejun Heo
2022-03-15 0:30 ` [PATCH v3 " Tejun Heo
2022-03-15 1:15 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=164730690621.219116.11184082869298025827.b4-ty@kernel.dk \
--to=axboe@kernel.dk \
--cc=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®