From: Tejun Heo <tj@kernel.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, kernel-team@fb.com,
linux-kernel@vger.kernel.org, Josef Bacik <josef@toxicpanda.com>
Subject: Re: [PATCH block-5.17] block: don't merge across cgroup boundaries if iocost or iolatency is active
Date: Mon, 14 Mar 2022 10:41:38 -1000 [thread overview]
Message-ID: <Yi+ogt9ahz3yr9RE@slm.duckdns.org> (raw)
In-Reply-To: <107965ce-a29a-b5f4-ef87-63b753380891@kernel.dk>
On Mon, Mar 14, 2022 at 02:12:34PM -0600, Jens Axboe wrote:
> > * Add WARN_ON_ONCE() on blkg mismatch in ioc_rqos_merge() so that we can
> > easily notice similar failures in the future.
> >
> > * Make sure iocost enable/disable transitions only happen when iocost is
> > actually enabled / disabled.
>
> Is there really no better way to do this than add a lot of expensive
> checks to the fast path?
>
> Even just inverting the checks so that
>
> if (req->bio->bi_blkg != bio->bi_blkg)
> ...
>
> is checked first would seem a lot saner.
>
> In any case, since this isn't a new regression, I'd feel a lot better
> deferring it to 5.18.
As discussed, the only risk of removing the disable/enable switch and always
testing is ruining some merges for cases where blkcg is enabled but no
control is applied, which shouldn't be a big problem. I'll redo the patch.
Thanks.
--
tejun
next parent reply other threads:[~2022-03-14 20:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Yi71WZ3O9/YViHSb@slm.duckdns.org>
[not found] ` <107965ce-a29a-b5f4-ef87-63b753380891@kernel.dk>
2022-03-14 20:41 ` Tejun Heo [this message]
2022-03-14 23:50 ` [PATCH v2 for-5.18/block] block: don't merge across cgroup boundaries if blkcg is enabled Tejun Heo
2022-03-15 0:30 ` [PATCH v3 " Tejun Heo
2022-03-15 1:15 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yi+ogt9ahz3yr9RE@slm.duckdns.org \
--to=tj@kernel.org \
--cc=axboe@kernel.dk \
--cc=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®