From: Jens Axboe <axboe@kernel.dk>
To: Philipp Reisner <philipp.reisner@linbit.com>,
Jakob Koschel <jakobkoschel@gmail.com>
Cc: Mike Rapoport <rppt@kernel.org>,
Lars Ellenberg <lars.ellenberg@linbit.com>,
drbd-dev@lists.linbit.com, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, "Bos, H.J." <h.j.bos@vu.nl>,
Cristiano Giuffrida <c.giuffrida@vu.nl>,
Brian Johannesmeyer <bjohannesmeyer@gmail.com>
Subject: Re: [PATCH 1/2] drbd: remove usage of list iterator variable after loop for list_for_each_entry_safe_from()
Date: Fri, 01 Apr 2022 17:56:42 -0600 [thread overview]
Message-ID: <164885740219.761778.5044909883791536138.b4-ty@kernel.dk> (raw)
In-Reply-To: <20220331220349.885126-1-jakobkoschel@gmail.com>
On Fri, 1 Apr 2022 00:03:48 +0200, Jakob Koschel wrote:
> In preparation to limit the scope of a list iterator to the list
> traversal loop, use a dedicated pointer to iterate through the list [1].
>
> Since that variable should not be used past the loop iteration, a
> separate variable is used to 'remember the current location within the
> loop'.
>
> [...]
Applied, thanks!
[1/2] drbd: remove usage of list iterator variable after loop for list_for_each_entry_safe_from()
commit: 901aeda62efa21f2eae937bccb71b49ae531be06
[2/2] drbd: remove check of list iterator against head past the loop body
commit: 2651ee5ae43241831ca63d7158bb2b151a6a0e1f
Best regards,
--
Jens Axboe
prev parent reply other threads:[~2022-04-01 23:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-31 22:03 Jakob Koschel
2022-03-31 22:03 ` [PATCH 2/2] drbd: remove check of list iterator against head past the loop body Jakob Koschel
2022-03-31 22:28 ` [Drbd-dev] " Christoph Böhmwalder
2022-03-31 23:09 ` Jens Axboe
2022-04-01 23:56 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=164885740219.761778.5044909883791536138.b4-ty@kernel.dk \
--to=axboe@kernel.dk \
--cc=bjohannesmeyer@gmail.com \
--cc=c.giuffrida@vu.nl \
--cc=drbd-dev@lists.linbit.com \
--cc=h.j.bos@vu.nl \
--cc=jakobkoschel@gmail.com \
--cc=lars.ellenberg@linbit.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=philipp.reisner@linbit.com \
--cc=rppt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®