From: Jens Axboe <axboe@kernel.dk>
To: chaitanya.kulkarni@wdc.com, shinichiro.kawasaki@wdc.com,
yukuai3@huawei.com
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
yi.zhang@huawei.com
Subject: Re: [PATCH] null-blk: save memory footprint for struct nullb_cmd
Date: Mon, 25 Apr 2022 20:31:38 -0600 [thread overview]
Message-ID: <165094029875.72509.3390339725421776639.b4-ty@kernel.dk> (raw)
In-Reply-To: <20220426022133.3999006-1-yukuai3@huawei.com>
On Tue, 26 Apr 2022 10:21:33 +0800, Yu Kuai wrote:
> Total 16 bytes can be saved in two ways:
>
> 1) The field 'bio' will only be used in bio based mode, and the field
> 'rq' will only be used in mq mode. Since they won't be used in the
> same time, declare a union for them.
> 2) The field 'bool fake_timeout' can be placed in the hole after the
> field 'error'.
>
> [...]
Applied, thanks!
[1/1] null-blk: save memory footprint for struct nullb_cmd
commit: 8ba816b23abd2a9a05705f3d00b8653f8be73015
Best regards,
--
Jens Axboe
next prev parent reply other threads:[~2022-04-26 2:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-26 2:21 Yu Kuai
2022-04-26 2:31 ` Jens Axboe [this message]
2022-04-26 6:20 ` Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=165094029875.72509.3390339725421776639.b4-ty@kernel.dk \
--to=axboe@kernel.dk \
--cc=chaitanya.kulkarni@wdc.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shinichiro.kawasaki@wdc.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®