From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Yu Kuai <yukuai3@huawei.com>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"shinichiro.kawasaki@wdc.com" <shinichiro.kawasaki@wdc.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"axboe@kernel.dk" <axboe@kernel.dk>,
"yi.zhang@huawei.com" <yi.zhang@huawei.com>,
"chaitanya.kulkarni@wdc.com" <chaitanya.kulkarni@wdc.com>
Subject: Re: [PATCH] null-blk: save memory footprint for struct nullb_cmd
Date: Tue, 26 Apr 2022 06:20:19 +0000 [thread overview]
Message-ID: <3662c725-a919-443a-9ab8-dc536cb5c03b@nvidia.com> (raw)
In-Reply-To: <20220426022133.3999006-1-yukuai3@huawei.com>
On 4/25/22 19:21, Yu Kuai wrote:
> Total 16 bytes can be saved in two ways:
>
> 1) The field 'bio' will only be used in bio based mode, and the field
> 'rq' will only be used in mq mode. Since they won't be used in the
> same time, declare a union for them.
> 2) The field 'bool fake_timeout' can be placed in the hole after the
> field 'error'.
>
> Signed-off-by: Yu Kuai <yukuai3@huawei.com>
> ---
Looks good.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
prev parent reply other threads:[~2022-04-26 6:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-26 2:21 Yu Kuai
2022-04-26 2:31 ` Jens Axboe
2022-04-26 6:20 ` Chaitanya Kulkarni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3662c725-a919-443a-9ab8-dc536cb5c03b@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=axboe@kernel.dk \
--cc=chaitanya.kulkarni@wdc.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shinichiro.kawasaki@wdc.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®