* [PATCH] ASoC: codecs: da7210: add check for i2c_add_driver
@ 2022-05-31 9:47 Jiasheng Jiang
2022-06-07 10:46 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Jiasheng Jiang @ 2022-05-31 9:47 UTC (permalink / raw)
To: support.opensource, lgirdwood, broonie, perex, tiwai
Cc: alsa-devel, linux-kernel, Jiasheng Jiang
As i2c_add_driver could return error if fails, it should be
better to check the return value.
However, if the CONFIG_I2C and CONFIG_SPI_MASTER are both true,
the return value of i2c_add_driver will be covered by
spi_register_driver.
Therefore, it is necessary to add check and return error if fails.
Fixes: aa0e25caafb7 ("ASoC: da7210: Add support for spi regmap")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
---
sound/soc/codecs/da7210.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/sound/soc/codecs/da7210.c b/sound/soc/codecs/da7210.c
index 3fa3042e4424..76a21976ccdd 100644
--- a/sound/soc/codecs/da7210.c
+++ b/sound/soc/codecs/da7210.c
@@ -1335,6 +1335,8 @@ static int __init da7210_modinit(void)
int ret = 0;
#if IS_ENABLED(CONFIG_I2C)
ret = i2c_add_driver(&da7210_i2c_driver);
+ if (ret)
+ return ret;
#endif
#if defined(CONFIG_SPI_MASTER)
ret = spi_register_driver(&da7210_spi_driver);
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] ASoC: codecs: da7210: add check for i2c_add_driver
2022-05-31 9:47 [PATCH] ASoC: codecs: da7210: add check for i2c_add_driver Jiasheng Jiang
@ 2022-06-07 10:46 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2022-06-07 10:46 UTC (permalink / raw)
To: tiwai, support.opensource, lgirdwood, perex, jiasheng
Cc: linux-kernel, alsa-devel
On Tue, 31 May 2022 17:47:12 +0800, Jiasheng Jiang wrote:
> As i2c_add_driver could return error if fails, it should be
> better to check the return value.
> However, if the CONFIG_I2C and CONFIG_SPI_MASTER are both true,
> the return value of i2c_add_driver will be covered by
> spi_register_driver.
> Therefore, it is necessary to add check and return error if fails.
>
> [...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] ASoC: codecs: da7210: add check for i2c_add_driver
commit: 82fa8f581a954ddeec1602bed9f8b4a09d100e6e
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-06-07 10:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-31 9:47 [PATCH] ASoC: codecs: da7210: add check for i2c_add_driver Jiasheng Jiang
2022-06-07 10:46 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®