* [PATCH net] net: axienet: add missing error return code in axienet_probe()
@ 2022-06-16 6:29 Yang Yingliang
2022-06-16 18:40 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Yang Yingliang @ 2022-06-16 6:29 UTC (permalink / raw)
To: linux-kernel, netdev
Cc: radhey.shyam.pandey, davem, edumazet, kuba, andy.chiu, max.hsu,
greentime.hu
It should return error code in error path in axienet_probe().
Fixes: 00be43a74ca2 ("net: axienet: make the 64b addresable DMA depends on 64b archectures")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
index fa7bcd2c1892..1760930ec0c4 100644
--- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
+++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
@@ -2039,6 +2039,7 @@ static int axienet_probe(struct platform_device *pdev)
}
if (!IS_ENABLED(CONFIG_64BIT) && lp->features & XAE_FEATURE_DMA_64BIT) {
dev_err(&pdev->dev, "64-bit addressable DMA is not compatible with 32-bit archecture\n");
+ ret = -EINVAL;
goto cleanup_clk;
}
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH net] net: axienet: add missing error return code in axienet_probe()
2022-06-16 6:29 [PATCH net] net: axienet: add missing error return code in axienet_probe() Yang Yingliang
@ 2022-06-16 18:40 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-06-16 18:40 UTC (permalink / raw)
To: Yang Yingliang
Cc: linux-kernel, netdev, radhey.shyam.pandey, davem, edumazet, kuba,
andy.chiu, max.hsu, greentime.hu
Hello:
This patch was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Thu, 16 Jun 2022 14:29:17 +0800 you wrote:
> It should return error code in error path in axienet_probe().
>
> Fixes: 00be43a74ca2 ("net: axienet: make the 64b addresable DMA depends on 64b archectures")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
> drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 1 +
> 1 file changed, 1 insertion(+)
Here is the summary with links:
- [net] net: axienet: add missing error return code in axienet_probe()
https://git.kernel.org/netdev/net/c/2e7bf4a6af48
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-06-16 18:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-16 6:29 [PATCH net] net: axienet: add missing error return code in axienet_probe() Yang Yingliang
2022-06-16 18:40 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®