* [PATCH][PPC32] Don't synchronize in disable_irq() if no handler
@ 2004-06-03 10:32 Paul Mackerras
0 siblings, 0 replies; only message in thread
From: Paul Mackerras @ 2004-06-03 10:32 UTC (permalink / raw)
To: akpm, torvalds; +Cc: linux-kernel, benh, trini
This patch is the ppc32 counterpart to a fix that went into
arch/i386/kernel/irq.c last October. The bug was noted by Al Viro: if
no handler exists, and we have IRQ_INPROGRESS set because of an
earlier irq that got through, synchronize_irq() will end up waiting
forever.
Signed-off-by: Paul Mackerras <paulus@samba.org>
diff -urN linux-2.5/arch/ppc/kernel/irq.c pmac-2.5/arch/ppc/kernel/irq.c
--- linux-2.5/arch/ppc/kernel/irq.c 2004-02-23 12:05:11.000000000 +1100
+++ pmac-2.5/arch/ppc/kernel/irq.c 2004-03-11 16:49:24.000000000 +1100
@@ -304,8 +304,10 @@
void disable_irq(unsigned int irq)
{
+ irq_desc_t *desc = irq_desc + irq;
disable_irq_nosync(irq);
- synchronize_irq(irq);
+ if (desc->action)
+ synchronize_irq(irq);
}
/**
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2004-06-03 10:37 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-06-03 10:32 [PATCH][PPC32] Don't synchronize in disable_irq() if no handler Paul Mackerras
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®