Re: 2.6.7-rc2: no more AGP?

[Paul Mackerras <paulus@samba.org>]

Benjamin Herrenschmidt writes:

> On Fri, 2004-06-04 at 10:48, Colin Leroy wrote:
> > Hi,
> > 
> > just a lousy bugreport... I noticed that agpgart doesn't work anymore on
> > 2.6.7-rc2. Xorg reports that AGP isn't supported, and dmesg doesn't show
> > the
> > agpgart: Putting AGP V2 device at 0000:00:0b.0 into 4x mode
> > agpgart: Putting AGP V2 device at 0000:00:10.0 into 4x mode
> > 
> > It only shows
> > Linux agpgart interface v0.100 (c) Dave Jones
> > agpgart: Detected Apple UniNorth 2 chipset
> > agpgart: Maximum main memory to use for agp memory: 565M
> > agpgart: configuring for size idx: 4
> > agpgart: AGP aperture is 16M @ 0x0
> 
> Right, something seems broken. I'm also having problems with USB
> sleep & wakeup and with cpufreq. Argh, I've been away from ppc32 for
> too long !

You need this patch.  Michel Daenzer tells me that the
cant_use_aperture check isn't needed.

Paul.

diff -urN linux-2.5/drivers/char/drm/drm_agpsupport.h pmac-2.5/drivers/char/drm/drm_agpsupport.h
--- linux-2.5/drivers/char/drm/drm_agpsupport.h	2004-05-11 13:19:51.000000000 +1000
+++ pmac-2.5/drivers/char/drm/drm_agpsupport.h	2004-05-28 22:21:33.000000000 +1000
@@ -109,8 +109,6 @@
 		return -EBUSY;
 	if (!drm_agp->acquire)
 		return -EINVAL;
-	if ( dev->agp->cant_use_aperture )
-		return -EINVAL;
 	if ((retcode = drm_agp->acquire()))
 		return retcode;
 	dev->agp->acquired = 1;