From: Colin Leroy <colin@colino.net>
To: akpm@asdl.org
Cc: Michel D_nzer <michel@daenzer.net>,
Benjamin <benh@kernel.crashing.org>,
linux-kernel@vger.kernel.org, dri-devel@lists.sf.net
Subject: [PATCH] 2.6.7-rc2: fix agpgart
Date: Fri, 4 Jun 2004 21:39:07 +0200 [thread overview]
Message-ID: <20040604213907.395b01aa@jack.colino.net> (raw)
In-Reply-To: <1086366108.4243.117.camel@localhost>
On 04 Jun 2004 at 18h06, Michel Dänzer wrote:
Hi,
> Paulus brought this up on IRC, it seems to be a bad DRM merge: The
> code
>
> #ifndef VMAP_4_ARGS
> if ( dev->agp->cant_use_aperture )
> return -EINVAL;
> #endif
>
> in DRM(agp_acquire) should be removed altogether in a 2.6 kernel
> because its vmap() takes 4 arguments; however, only the guards seem to
> have been removed, which causes this function to erroneously fail if
> the AGP aperture can't be directly accessed by the CPU.
Looks like. Removing it fixes the problem. Here's the patch...
Signed-off-by: Colin Leroy <colin@colino.net>
--- a/drivers/char/drm/drm_agpsupport.h 2004-06-04 17:44:23.000000000 +0200
+++ b/drivers/char/drm/drm_agpsupport.h 2004-06-04 21:01:03.000000000 +0200
@@ -109,8 +109,6 @@
return -EBUSY;
if (!drm_agp->acquire)
return -EINVAL;
- if ( dev->agp->cant_use_aperture )
- return -EINVAL;
if ((retcode = drm_agp->acquire()))
return retcode;
dev->agp->acquired = 1;
next prev parent reply other threads:[~2004-06-04 19:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-04 15:48 2.6.7-rc2: no more AGP? Colin Leroy
2004-06-04 16:17 ` Benjamin Herrenschmidt
2004-06-05 3:36 ` Paul Mackerras
2004-06-04 16:21 ` Michel Dänzer
2004-06-04 19:39 ` Colin Leroy [this message]
2004-06-05 8:23 ` [PATCH] 2.6.7-rc2: fix agpgart Dave Airlie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040604213907.395b01aa@jack.colino.net \
--to=colin@colino.net \
--cc=akpm@asdl.org \
--cc=benh@kernel.crashing.org \
--cc=dri-devel@lists.sf.net \
--cc=linux-kernel@vger.kernel.org \
--cc=michel@daenzer.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®