mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Bouron, Justinien" <jbouron@amazon.com>
To: Baoquan He <bhe@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
	Petr Mladek <pmladek@suse.com>,
	"Mario Limonciello" <mario.limonciello@amd.com>,
	Marcos Paulo de Souza <mpdesouza@suse.com>, "Graf (AWS),
	Alexander" <graf@amazon.de>,
	Steven Chen <chenste@linux.microsoft.com>,
	Yan Zhao <yan.y.zhao@intel.com>,
	"kexec@lists.infradead.org" <kexec@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Kudrjavets, Gunnar" <gunnarku@amazon.com>
Subject: Re: [PATCH] kexec_core: Remove superfluous page offset handling in segment loading
Date: Thu, 11 Sep 2025 15:30:19 +0000	[thread overview]
Message-ID: <1659446A-F17C-4FF2-BE1B-3EC37520DDCB@amazon.com> (raw)
In-Reply-To: <aMKZUY/zg31qN+68@MiWiFi-R3L-srv>

On 9/11/25, 02:42, "Baoquan He" <bhe@redhat.com <mailto:bhe@redhat.com>> wrote:
> Do you mean we will adjust the memsz and buf_align to PAGE_SIZE aligned
> in kexec_add_buffer()?
That and mostly the fact that `sanity_check_segment_list()` explicitely rejects
any segment that either does not start or end on a page boundary:

int sanity_check_segment_list(struct kimage *image)
{
    // ...
    for (i = 0; i < nr_segments; i++) {
        unsigned long mstart, mend;

        mstart = image->segment[i].mem;
        mend   = mstart + image->segment[i].memsz;
        if (mstart > mend)
            return -EADDRNOTAVAIL;
        if ((mstart & ~PAGE_MASK) || (mend & ~PAGE_MASK))
            return -EADDRNOTAVAIL;
        if (mend >= KEXEC_DESTINATION_MEMORY_LIMIT)
            return -EADDRNOTAVAIL;
    }
    // ...
}

> That better be explained in log.
Does it warrant a second revision to change the log?

Thanks,
Justinien


  reply	other threads:[~2025-09-11 15:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-10 16:31 Justinien Bouron
2025-09-11  9:41 ` Baoquan He
2025-09-11 15:30   ` Bouron, Justinien [this message]
2025-09-12  6:11     ` Baoquan He
2025-09-23  3:07       ` Andrew Morton
2025-09-11 13:24 ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1659446A-F17C-4FF2-BE1B-3EC37520DDCB@amazon.com \
    --to=jbouron@amazon.com \
    --cc=akpm@linux-foundation.org \
    --cc=bhe@redhat.com \
    --cc=chenste@linux.microsoft.com \
    --cc=graf@amazon.de \
    --cc=gunnarku@amazon.com \
    --cc=kexec@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mario.limonciello@amd.com \
    --cc=mpdesouza@suse.com \
    --cc=pmladek@suse.com \
    --cc=rafael.j.wysocki@intel.com \
    --cc=yan.y.zhao@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®