From: Justinien Bouron <jbouron@amazon.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Baoquan He <bhe@redhat.com>,
"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
Petr Mladek <pmladek@suse.com>,
Mario Limonciello <mario.limonciello@amd.com>,
"Marcos Paulo de Souza" <mpdesouza@suse.com>,
Alexander Graf <graf@amazon.com>,
Justinien Bouron <jbouron@amazon.com>,
Steven Chen <chenste@linux.microsoft.com>,
Yan Zhao <yan.y.zhao@intel.com>, <kexec@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Cc: Gunnar Kudrjavets <gunnarku@amazon.com>
Subject: [PATCH] kexec_core: Remove superfluous page offset handling in segment loading
Date: Wed, 10 Sep 2025 09:31:16 -0700 [thread overview]
Message-ID: <20250910163116.49148-1-jbouron@amazon.com> (raw)
Kexec does not accept segments for which the destination address is not
page aligned. Therefore there is no need for page offset handling when
loading segments.
Signed-off-by: Justinien Bouron <jbouron@amazon.com>
Reviewed-by: Gunnar Kudrjavets <gunnarku@amazon.com>
---
kernel/kexec_core.c | 13 ++++---------
1 file changed, 4 insertions(+), 9 deletions(-)
diff --git a/kernel/kexec_core.c b/kernel/kexec_core.c
index 31203f0bacaf..7d4c9eebea79 100644
--- a/kernel/kexec_core.c
+++ b/kernel/kexec_core.c
@@ -761,9 +761,7 @@ static int kimage_load_cma_segment(struct kimage *image, int idx)
while (mbytes) {
size_t uchunk, mchunk;
- ptr += maddr & ~PAGE_MASK;
- mchunk = min_t(size_t, mbytes,
- PAGE_SIZE - (maddr & ~PAGE_MASK));
+ mchunk = min_t(size_t, mbytes, PAGE_SIZE);
uchunk = min(ubytes, mchunk);
if (uchunk) {
@@ -815,6 +813,7 @@ static int kimage_load_normal_segment(struct kimage *image, int idx)
mbytes = segment->memsz;
maddr = segment->mem;
+
if (image->segment_cma[idx])
return kimage_load_cma_segment(image, idx);
@@ -840,9 +839,7 @@ static int kimage_load_normal_segment(struct kimage *image, int idx)
ptr = kmap_local_page(page);
/* Start with a clear page */
clear_page(ptr);
- ptr += maddr & ~PAGE_MASK;
- mchunk = min_t(size_t, mbytes,
- PAGE_SIZE - (maddr & ~PAGE_MASK));
+ mchunk = min_t(size_t, mbytes, PAGE_SIZE);
uchunk = min(ubytes, mchunk);
if (uchunk) {
@@ -905,9 +902,7 @@ static int kimage_load_crash_segment(struct kimage *image, int idx)
}
arch_kexec_post_alloc_pages(page_address(page), 1, 0);
ptr = kmap_local_page(page);
- ptr += maddr & ~PAGE_MASK;
- mchunk = min_t(size_t, mbytes,
- PAGE_SIZE - (maddr & ~PAGE_MASK));
+ mchunk = min_t(size_t, mbytes, PAGE_SIZE);
uchunk = min(ubytes, mchunk);
if (mchunk > uchunk) {
/* Zero the trailing part of the page */
--
2.43.0
next reply other threads:[~2025-09-10 16:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-10 16:31 Justinien Bouron [this message]
2025-09-11 9:41 ` Baoquan He
2025-09-11 15:30 ` Bouron, Justinien
2025-09-12 6:11 ` Baoquan He
2025-09-23 3:07 ` Andrew Morton
2025-09-11 13:24 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250910163116.49148-1-jbouron@amazon.com \
--to=jbouron@amazon.com \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=chenste@linux.microsoft.com \
--cc=graf@amazon.com \
--cc=gunnarku@amazon.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=mpdesouza@suse.com \
--cc=pmladek@suse.com \
--cc=rafael.j.wysocki@intel.com \
--cc=yan.y.zhao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®