* [PATCH linux-next] block/rnbd-clt: Remove the unneeded result variable
@ 2022-08-24 7:52 cgel.zte
2022-08-24 14:30 ` Jinpu Wang
2022-08-24 14:51 ` Jens Axboe
0 siblings, 2 replies; 3+ messages in thread
From: cgel.zte @ 2022-08-24 7:52 UTC (permalink / raw)
To: axboe
Cc: haris.iqbal, jinpu.wang, linux-block, linux-kernel, ye xingchen,
Zeal Robot
From: ye xingchen <ye.xingchen@zte.com.cn>
Return the value from rtrs_clt_rdma_cq_direct() directly instead of
storing it in another redundant variable.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
---
drivers/block/rnbd/rnbd-clt.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/block/rnbd/rnbd-clt.c b/drivers/block/rnbd/rnbd-clt.c
index 9d01e7ab33e4..78334da74d8b 100644
--- a/drivers/block/rnbd/rnbd-clt.c
+++ b/drivers/block/rnbd/rnbd-clt.c
@@ -1159,10 +1159,8 @@ static int rnbd_rdma_poll(struct blk_mq_hw_ctx *hctx, struct io_comp_batch *iob)
{
struct rnbd_queue *q = hctx->driver_data;
struct rnbd_clt_dev *dev = q->dev;
- int cnt;
- cnt = rtrs_clt_rdma_cq_direct(dev->sess->rtrs, hctx->queue_num);
- return cnt;
+ return rtrs_clt_rdma_cq_direct(dev->sess->rtrs, hctx->queue_num);
}
static void rnbd_rdma_map_queues(struct blk_mq_tag_set *set)
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH linux-next] block/rnbd-clt: Remove the unneeded result variable
2022-08-24 7:52 [PATCH linux-next] block/rnbd-clt: Remove the unneeded result variable cgel.zte
@ 2022-08-24 14:30 ` Jinpu Wang
2022-08-24 14:51 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Jinpu Wang @ 2022-08-24 14:30 UTC (permalink / raw)
To: cgel.zte
Cc: axboe, haris.iqbal, linux-block, linux-kernel, ye xingchen, Zeal Robot
On Wed, Aug 24, 2022 at 9:52 AM <cgel.zte@gmail.com> wrote:
>
> From: ye xingchen <ye.xingchen@zte.com.cn>
>
> Return the value from rtrs_clt_rdma_cq_direct() directly instead of
> storing it in another redundant variable.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn
Acked-by: Jack Wang <jinpu.wang@ionos.com>
thx!
> ---
> drivers/block/rnbd/rnbd-clt.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/block/rnbd/rnbd-clt.c b/drivers/block/rnbd/rnbd-clt.c
> index 9d01e7ab33e4..78334da74d8b 100644
> --- a/drivers/block/rnbd/rnbd-clt.c
> +++ b/drivers/block/rnbd/rnbd-clt.c
> @@ -1159,10 +1159,8 @@ static int rnbd_rdma_poll(struct blk_mq_hw_ctx *hctx, struct io_comp_batch *iob)
> {
> struct rnbd_queue *q = hctx->driver_data;
> struct rnbd_clt_dev *dev = q->dev;
> - int cnt;
>
> - cnt = rtrs_clt_rdma_cq_direct(dev->sess->rtrs, hctx->queue_num);
> - return cnt;
> + return rtrs_clt_rdma_cq_direct(dev->sess->rtrs, hctx->queue_num);
> }
>
> static void rnbd_rdma_map_queues(struct blk_mq_tag_set *set)
> --
> 2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH linux-next] block/rnbd-clt: Remove the unneeded result variable
2022-08-24 7:52 [PATCH linux-next] block/rnbd-clt: Remove the unneeded result variable cgel.zte
2022-08-24 14:30 ` Jinpu Wang
@ 2022-08-24 14:51 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2022-08-24 14:51 UTC (permalink / raw)
To: cgel.zte
Cc: Zeal Robot, ye xingchen, linux-kernel, jinpu.wang, haris.iqbal,
linux-block
On Wed, 24 Aug 2022 07:52:13 +0000, cgel.zte@gmail.com wrote:
> From: ye xingchen <ye.xingchen@zte.com.cn>
>
> Return the value from rtrs_clt_rdma_cq_direct() directly instead of
> storing it in another redundant variable.
>
>
Applied, thanks!
[1/1] block/rnbd-clt: Remove the unneeded result variable
commit: f2cc648e12285c53365c2bcacbcd919022f4d3a8
Best regards,
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-08-24 14:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-24 7:52 [PATCH linux-next] block/rnbd-clt: Remove the unneeded result variable cgel.zte
2022-08-24 14:30 ` Jinpu Wang
2022-08-24 14:51 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®