From: Paul Mackerras <paulus@samba.org>
To: Ryan Arnold <rsa@us.ibm.com>
Cc: Andrew Morton <akpm@osdl.org>,
Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [announce] HVCS for inclusion in 2.6 tree
Date: Sun, 18 Jul 2004 12:00:15 +1000 [thread overview]
Message-ID: <16633.55727.513217.364467@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <1089819720.3385.66.camel@localhost>
Ryan,
> I would like the attached HVCS driver considered for inclusion into the
> 2.6 mainline tree. This is a ppc64 platform driver so I figured that
> maybe Paul MacKerras would like to sign off on the arch specific
> segments of this driver before inclusion.
The arch/ppc64 stuff mostly looks OK - however I would prefer that you
created a new arch/ppc64/kernel/hvcs.c (and include/asm-ppc64/hvcs.h)
rather than tripling the size of the existing hvconsole.c. There are
a couple of whitespace nits (missing space after "if" in a couple of
places), and this:
> +#define HVCS_LONG_INVALID 0xFFFFFFFFFFFFFFFF
would look better as either ~0UL or -1L (and I don't see why it really
needs a #define).
Regards,
Paul.
next prev parent reply other threads:[~2004-07-18 18:12 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-14 15:42 Ryan Arnold
2004-07-18 2:00 ` Paul Mackerras [this message]
2004-07-19 15:54 ` Ryan Arnold
2004-07-22 20:26 ` Ryan Arnold
2004-07-23 1:57 ` Andrew Morton
2004-07-26 14:41 ` Ryan Arnold
2004-07-23 2:16 ` Andrew Morton
2004-07-27 20:08 ` [announce][draft3] " Ryan Arnold
2004-07-27 22:50 ` Randy.Dunlap
2004-07-28 16:39 ` Ryan Arnold
2004-07-28 20:12 ` Randy.Dunlap
2004-07-28 20:18 ` [announce][draft4] " Ryan Arnold
2004-07-29 17:41 ` Jeff Garzik
2004-08-02 14:24 ` Ryan Arnold
2004-07-28 20:36 ` [announce][draft3] " Paul Mackerras
2004-07-28 17:00 ` Ryan Arnold
2004-07-27 23:02 ` Randy.Dunlap
2004-07-23 2:21 ` [announce] " Andrew Morton
2004-07-26 12:57 ` Ryan Arnold
2004-07-23 2:29 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16633.55727.513217.364467@cargo.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rsa@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®