mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v2 0/2] Add some models into acp6x quirk list
@ 2022-09-20 19:46 Mario Limonciello
  2022-09-20 19:46 ` [PATCH v2 1/2] ASoC: amd: yc: Add ASUS UM5302TA into DMI table Mario Limonciello
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Mario Limonciello @ 2022-09-20 19:46 UTC (permalink / raw)
  To: Mark Brown
  Cc: Saba Kareem Syed, Xiaoyan Li, Travis Glenn Hansen, Sebastian S,
	Mario Limonciello, alsa-devel, linux-kernel

Another model from ASUS and Lenovo have been identified that
don't include anything in ACPI tables to indicate they require the
ACP6x DMIC driver to be loaded.

This series adds them both to the quirk list.

changes from v1->v2:
 * Both models were independently sent in v1 but touch the same code,
   so v2 collates them together.

Mario Limonciello (1):
  ASoC: amd: yc: Add Lenovo Yoga Slim 7 Pro X to quirks table

Xiaoyan Li (1):
  ASoC: amd: yc: Add ASUS UM5302TA into DMI table

 sound/soc/amd/yc/acp6x-mach.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

-- 
2.34.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH v2 1/2] ASoC: amd: yc: Add ASUS UM5302TA into DMI table
  2022-09-20 19:46 [PATCH v2 0/2] Add some models into acp6x quirk list Mario Limonciello
@ 2022-09-20 19:46 ` Mario Limonciello
  2022-09-20 20:10   ` Mark Brown
  2022-09-20 19:46 ` [PATCH v2 2/2] ASoC: amd: yc: Add Lenovo Yoga Slim 7 Pro X to quirks table Mario Limonciello
  2022-09-21  9:25 ` [PATCH v2 0/2] Add some models into acp6x quirk list Mark Brown
  2 siblings, 1 reply; 5+ messages in thread
From: Mario Limonciello @ 2022-09-20 19:46 UTC (permalink / raw)
  To: Mark Brown, linux-kernel
  Cc: Saba Kareem Syed, Xiaoyan Li, Travis Glenn Hansen, Sebastian S,
	Mario Limonciello, Liam Girdwood, Jaroslav Kysela, Takashi Iwai,
	alsa-devel

From: Xiaoyan Li <lxy.lixiaoyan@gmail.com>

ASUS Zenbook S 13 OLED (UM5302TA) needs this quirk to get the built-in
microphone working properly.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=216270
Signed-off-by: Xiaoyan Li <lxy.lixiaoyan@gmail.com>
Suggested-by: Mario Limonciello <mario.limonciello@amd.com>
Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
---
 sound/soc/amd/yc/acp6x-mach.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c
index e0b24e1daef3..5eab3baf3573 100644
--- a/sound/soc/amd/yc/acp6x-mach.c
+++ b/sound/soc/amd/yc/acp6x-mach.c
@@ -171,6 +171,13 @@ static const struct dmi_system_id yc_acp_quirk_table[] = {
 			DMI_MATCH(DMI_PRODUCT_NAME, "21J6"),
 		}
 	},
+	{
+		.driver_data = &acp6x_card,
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK COMPUTER INC."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "UM5302TA"),
+		}
+	},
 	{}
 };
 
-- 
2.34.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH v2 2/2] ASoC: amd: yc: Add Lenovo Yoga Slim 7 Pro X to quirks table
  2022-09-20 19:46 [PATCH v2 0/2] Add some models into acp6x quirk list Mario Limonciello
  2022-09-20 19:46 ` [PATCH v2 1/2] ASoC: amd: yc: Add ASUS UM5302TA into DMI table Mario Limonciello
@ 2022-09-20 19:46 ` Mario Limonciello
  2022-09-21  9:25 ` [PATCH v2 0/2] Add some models into acp6x quirk list Mark Brown
  2 siblings, 0 replies; 5+ messages in thread
From: Mario Limonciello @ 2022-09-20 19:46 UTC (permalink / raw)
  To: Mark Brown, linux-kernel
  Cc: Saba Kareem Syed, Xiaoyan Li, Travis Glenn Hansen, Sebastian S,
	Mario Limonciello, Liam Girdwood, Jaroslav Kysela, Takashi Iwai,
	alsa-devel

Lenovo Yoga Slim 7 Pro X has an ACP DMIC that isn't specified in the
ASL or existing quirk list.  Add it to the quirk table to let DMIC
work on these systems.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=216299
Tested-by: Sebastian S <iam@decentr.al>
Reported-and-tested-by: Travis Glenn Hansen <travisghansen@yahoo.com>
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
 sound/soc/amd/yc/acp6x-mach.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c
index 5eab3baf3573..2cb50d5cf1a9 100644
--- a/sound/soc/amd/yc/acp6x-mach.c
+++ b/sound/soc/amd/yc/acp6x-mach.c
@@ -171,6 +171,13 @@ static const struct dmi_system_id yc_acp_quirk_table[] = {
 			DMI_MATCH(DMI_PRODUCT_NAME, "21J6"),
 		}
 	},
+	{
+		.driver_data = &acp6x_card,
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "82"),
+		}
+	},
 	{
 		.driver_data = &acp6x_card,
 		.matches = {
-- 
2.34.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v2 1/2] ASoC: amd: yc: Add ASUS UM5302TA into DMI table
  2022-09-20 19:46 ` [PATCH v2 1/2] ASoC: amd: yc: Add ASUS UM5302TA into DMI table Mario Limonciello
@ 2022-09-20 20:10   ` Mark Brown
  0 siblings, 0 replies; 5+ messages in thread
From: Mark Brown @ 2022-09-20 20:10 UTC (permalink / raw)
  To: Mario Limonciello
  Cc: linux-kernel, Saba Kareem Syed, Xiaoyan Li, Travis Glenn Hansen,
	Sebastian S, Liam Girdwood, Jaroslav Kysela, Takashi Iwai,
	alsa-devel

[-- Attachment #1: Type: text/plain, Size: 511 bytes --]

On Tue, Sep 20, 2022 at 02:46:20PM -0500, Mario Limonciello wrote:

> 
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=216270
> Signed-off-by: Xiaoyan Li <lxy.lixiaoyan@gmail.com>
> Suggested-by: Mario Limonciello <mario.limonciello@amd.com>
> Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
> ---

You've not provided a Signed-off-by for this so I can't do anything with
it, please see Documentation/process/submitting-patches.rst for details
on what this is and why it's important.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v2 0/2] Add some models into acp6x quirk list
  2022-09-20 19:46 [PATCH v2 0/2] Add some models into acp6x quirk list Mario Limonciello
  2022-09-20 19:46 ` [PATCH v2 1/2] ASoC: amd: yc: Add ASUS UM5302TA into DMI table Mario Limonciello
  2022-09-20 19:46 ` [PATCH v2 2/2] ASoC: amd: yc: Add Lenovo Yoga Slim 7 Pro X to quirks table Mario Limonciello
@ 2022-09-21  9:25 ` Mark Brown
  2 siblings, 0 replies; 5+ messages in thread
From: Mark Brown @ 2022-09-21  9:25 UTC (permalink / raw)
  To: Mario Limonciello
  Cc: Saba Kareem Syed, Sebastian S, linux-kernel, alsa-devel,
	Xiaoyan Li, Travis Glenn Hansen

On Tue, 20 Sep 2022 14:46:19 -0500, Mario Limonciello wrote:
> Another model from ASUS and Lenovo have been identified that
> don't include anything in ACPI tables to indicate they require the
> ACP6x DMIC driver to be loaded.
> 
> This series adds them both to the quirk list.
> 
> changes from v1->v2:
>  * Both models were independently sent in v1 but touch the same code,
>    so v2 collates them together.
> 
> [...]

Applied to

   broonie/sound.git for-next

Thanks!

[1/2] ASoC: amd: yc: Add ASUS UM5302TA into DMI table
      commit: 4df5b13dec9e1b5a12db47ee92eb3f7da5c3deb5
[2/2] ASoC: amd: yc: Add Lenovo Yoga Slim 7 Pro X to quirks table
      commit: 2232b2dd8cd4f1e6d554b2c3f6899ce36f791b67

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2022-09-21  9:25 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-20 19:46 [PATCH v2 0/2] Add some models into acp6x quirk list Mario Limonciello
2022-09-20 19:46 ` [PATCH v2 1/2] ASoC: amd: yc: Add ASUS UM5302TA into DMI table Mario Limonciello
2022-09-20 20:10   ` Mark Brown
2022-09-20 19:46 ` [PATCH v2 2/2] ASoC: amd: yc: Add Lenovo Yoga Slim 7 Pro X to quirks table Mario Limonciello
2022-09-21  9:25 ` [PATCH v2 0/2] Add some models into acp6x quirk list Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®