[PATCH] ASoC: qcom: fix unmet direct dependencies for SND_SOC_QDSP6

[PATCH] ASoC: qcom: fix unmet direct dependencies for SND_SOC_QDSP6

[Srinivas Kandagatla]

SND_SOC_QDSP6 already has COMPILE_TEST so remove that from
SND_SOC_SC8280XP and also add QCOM_APR dependencies to
SND_SOC_SC8280XP like other Qualcomm machine drivers.

This should also fix below warning:
on x86_64, when QCOM_APR is not set and COMPILE_TEST=y:

WARNING: unmet direct dependencies detected for SND_SOC_QDSP6
  Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y]
	&& SND_SOC_QCOM [=y] && QCOM_APR [=n] && COMMON_CLK [=y]
  Selected by [y]:
  - SND_SOC_SC8280XP [=y] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y]
	&& SND_SOC_QCOM [=y] && (QCOM_APR [=n] || COMPILE_TEST [=y]) &&
	 SOUNDWIRE [=y] && COMMON_CLK [=y]

Fixes: 295aeea6646a ("ASoC: qcom: add machine driver for sc8280xp")
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
 sound/soc/qcom/Kconfig | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/sound/soc/qcom/Kconfig b/sound/soc/qcom/Kconfig
index 1b0252ec4665..d0e59e07b1fc 100644
--- a/sound/soc/qcom/Kconfig
+++ b/sound/soc/qcom/Kconfig
@@ -175,8 +175,7 @@ config SND_SOC_SM8250
 
 config SND_SOC_SC8280XP
 	tristate "SoC Machine driver for SC8280XP boards"
-	depends on QCOM_APR || COMPILE_TEST
-	depends on SOUNDWIRE
+	depends on QCOM_APR && SOUNDWIRE
 	depends on COMMON_CLK
 	select SND_SOC_QDSP6
 	select SND_SOC_QCOM_COMMON
-- 
2.25.1

Re: [PATCH] ASoC: qcom: fix unmet direct dependencies for SND_SOC_QDSP6

[Mark Brown]

On Fri, 30 Sep 2022 11:53:47 +0100, Srinivas Kandagatla wrote:
> SND_SOC_QDSP6 already has COMPILE_TEST so remove that from
> SND_SOC_SC8280XP and also add QCOM_APR dependencies to
> SND_SOC_SC8280XP like other Qualcomm machine drivers.
> 
> This should also fix below warning:
> on x86_64, when QCOM_APR is not set and COMPILE_TEST=y:
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: qcom: fix unmet direct dependencies for SND_SOC_QDSP6
      commit: 7bc08355a4917f2bbd38e7af5207f339f47e5d36

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark