* [PATCH] libbpf:fix overrun in attribute iteration
@ 2022-09-30 9:07 Xin Liu
2022-09-30 22:20 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Xin Liu @ 2022-09-30 9:07 UTC (permalink / raw)
To: quentin
Cc: andrii, ast, bpf, daniel, haoluo, john.fastabend, jolsa,
kongweibin2, kpsingh, linux-kernel, liuxin350, martin.lau, sdf,
song, wuchangye, xiesongyang, yanan, yhs, zhudi2
I accidentally found that a change in commit 1045b03e07d8 ("netlink: fix
overrun in attribute iteration") was not synchronized to the function
`nla_ok` in tools/lib/bpf/nlattr.c, I think it is necessary to modify,
this patch will do it.
Signed-off-by: Xin Liu <liuxin350@huawei.com>
---
tools/lib/bpf/nlattr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/lib/bpf/nlattr.c b/tools/lib/bpf/nlattr.c
index f57e77a6e40f..3900d052ed19 100644
--- a/tools/lib/bpf/nlattr.c
+++ b/tools/lib/bpf/nlattr.c
@@ -32,7 +32,7 @@ static struct nlattr *nla_next(const struct nlattr *nla, int *remaining)
static int nla_ok(const struct nlattr *nla, int remaining)
{
- return remaining >= sizeof(*nla) &&
+ return remaining >= (int)sizeof(*nla) &&
nla->nla_len >= sizeof(*nla) &&
nla->nla_len <= remaining;
}
--
2.33.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] libbpf:fix overrun in attribute iteration
2022-09-30 9:07 [PATCH] libbpf:fix overrun in attribute iteration Xin Liu
@ 2022-09-30 22:20 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-09-30 22:20 UTC (permalink / raw)
To: Xin Liu
Cc: quentin, andrii, ast, bpf, daniel, haoluo, john.fastabend, jolsa,
kongweibin2, kpsingh, linux-kernel, martin.lau, sdf, song,
wuchangye, xiesongyang, yanan, yhs, zhudi2
Hello:
This patch was applied to bpf/bpf-next.git (master)
by Andrii Nakryiko <andrii@kernel.org>:
On Fri, 30 Sep 2022 17:07:08 +0800 you wrote:
> I accidentally found that a change in commit 1045b03e07d8 ("netlink: fix
> overrun in attribute iteration") was not synchronized to the function
> `nla_ok` in tools/lib/bpf/nlattr.c, I think it is necessary to modify,
> this patch will do it.
>
> Signed-off-by: Xin Liu <liuxin350@huawei.com>
>
> [...]
Here is the summary with links:
- libbpf:fix overrun in attribute iteration
https://git.kernel.org/bpf/bpf-next/c/51e05a8cf8eb
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-09-30 22:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-30 9:07 [PATCH] libbpf:fix overrun in attribute iteration Xin Liu
2022-09-30 22:20 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®