* [PATCH net] net: prestera: span: do not unbind things things that were never bound
@ 2022-10-06 19:06 Maksym Glubokiy
2022-10-11 1:20 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Maksym Glubokiy @ 2022-10-06 19:06 UTC (permalink / raw)
To: Taras Chornyi, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Serhiy Boiko, Vadym Kochan, Volodymyr Mytnyk
Cc: Maksym Glubokiy, netdev, linux-kernel
Fixes: 13defa275eef ("net: marvell: prestera: Add matchall support")
Signed-off-by: Maksym Glubokiy <maksym.glubokiy@plvision.eu>
---
drivers/net/ethernet/marvell/prestera/prestera_span.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/marvell/prestera/prestera_span.c b/drivers/net/ethernet/marvell/prestera/prestera_span.c
index f0e9d6ea88c5..1005182ce3bc 100644
--- a/drivers/net/ethernet/marvell/prestera/prestera_span.c
+++ b/drivers/net/ethernet/marvell/prestera/prestera_span.c
@@ -107,7 +107,7 @@ static int prestera_span_put(struct prestera_switch *sw, u8 span_id)
entry = prestera_span_entry_find_by_id(sw->span, span_id);
if (!entry)
- return false;
+ return -ENOENT;
if (!refcount_dec_and_test(&entry->ref_count))
return 0;
@@ -151,6 +151,9 @@ int prestera_span_rule_del(struct prestera_flow_block_binding *binding,
{
int err;
+ if (binding->span_id == PRESTERA_SPAN_INVALID_ID)
+ return -ENOENT;
+
err = prestera_hw_span_unbind(binding->port, ingress);
if (err)
return err;
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH net] net: prestera: span: do not unbind things things that were never bound
2022-10-06 19:06 [PATCH net] net: prestera: span: do not unbind things things that were never bound Maksym Glubokiy
@ 2022-10-11 1:20 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-10-11 1:20 UTC (permalink / raw)
To: Maksym Glubokiy
Cc: tchornyi, davem, edumazet, kuba, pabeni, serhiy.boiko, vkochan,
vmytnyk, netdev, linux-kernel
Hello:
This patch was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Thu, 6 Oct 2022 22:06:00 +0300 you wrote:
> Fixes: 13defa275eef ("net: marvell: prestera: Add matchall support")
> Signed-off-by: Maksym Glubokiy <maksym.glubokiy@plvision.eu>
> ---
> drivers/net/ethernet/marvell/prestera/prestera_span.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
Here is the summary with links:
- [net] net: prestera: span: do not unbind things things that were never bound
https://git.kernel.org/netdev/net/c/32391e646a71
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-10-11 1:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-06 19:06 [PATCH net] net: prestera: span: do not unbind things things that were never bound Maksym Glubokiy
2022-10-11 1:20 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®