From: Heiko Stuebner <heiko@sntech.de>
To: John Keeping <john@metanate.com>, dri-devel@lists.freedesktop.org
Cc: Heiko Stuebner <heiko@sntech.de>,
linux-arm-kernel@lists.infradead.org,
Daniel Vetter <daniel@ffwll.ch>, Johan Jonker <jbx6244@gmail.com>,
linux-rockchip@lists.infradead.org,
Thomas Zimmermann <tzimmermann@suse.de>,
Sandy Huang <hjc@rock-chips.com>,
linux-kernel@vger.kernel.org, David Airlie <airlied@gmail.com>
Subject: Re: [PATCH] drm/rockchip: fix fbdev on non-IOMMU devices
Date: Sat, 29 Oct 2022 15:00:46 +0200 [thread overview]
Message-ID: <166704843772.1532410.11915201216204142960.b4-ty@sntech.de> (raw)
In-Reply-To: <20221020181248.2497065-1-john@metanate.com>
On Thu, 20 Oct 2022 19:12:47 +0100, John Keeping wrote:
> When switching to the generic fbdev infrastructure, it was missed that
> framebuffers were created with the alloc_kmap parameter to
> rockchip_gem_create_object() set to true. The generic infrastructure
> calls this via the .dumb_create() driver operation and thus creates a
> buffer without an associated kmap.
>
> alloc_kmap only makes a difference on devices without an IOMMU, but when
> it is missing rockchip_gem_prime_vmap() fails and the framebuffer cannot
> be used.
>
> [...]
Applied, thanks!
[1/1] drm/rockchip: fix fbdev on non-IOMMU devices
commit: ab78c74cfc5a3caa2bbb7627cb8f3bca40bb5fb0
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
prev parent reply other threads:[~2022-10-29 13:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-20 18:12 John Keeping
2022-10-29 13:00 ` Heiko Stuebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=166704843772.1532410.11915201216204142960.b4-ty@sntech.de \
--to=heiko@sntech.de \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=hjc@rock-chips.com \
--cc=jbx6244@gmail.com \
--cc=john@metanate.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®