From: Jens Axboe <axboe@kernel.dk>
To: Dawei Li <set_pte_at@outlook.com>
Cc: hch@lst.de, bvanassche@acm.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] block: simplify blksize_bits() implementation
Date: Mon, 31 Oct 2022 07:27:01 -0600 [thread overview]
Message-ID: <166722282123.67008.17742280061886191847.b4-ty@kernel.dk> (raw)
In-Reply-To: <TYCP286MB23238842958D7C083D6B67CECA349@TYCP286MB2323.JPNP286.PROD.OUTLOOK.COM>
On Sun, 30 Oct 2022 13:20:08 +0800, Dawei Li wrote:
> Convert current looping-based implementation into bit operation,
> which can bring improvement for:
>
> 1) bitops is more efficient for its arch-level optimization.
>
> 2) Given that blksize_bits() is inline, _if_ @size is compile-time
> constant, it's possible that order_base_2() _may_ make output
> compile-time evaluated, depending on code context and compiler behavior.
>
> [...]
Applied, thanks!
[1/1] block: simplify blksize_bits() implementation
commit: adff215830fcf3ef74f2f0d4dd5a47a6927d450b
Best regards,
--
Jens Axboe
prev parent reply other threads:[~2022-10-31 13:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-30 5:20 Dawei Li
2022-10-30 7:36 ` Christoph Hellwig
2022-10-30 14:34 ` Bart Van Assche
2022-10-31 2:03 ` Chaitanya Kulkarni
2022-10-31 13:27 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=166722282123.67008.17742280061886191847.b4-ty@kernel.dk \
--to=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=set_pte_at@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®