From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Dawei Li <set_pte_at@outlook.com>, "axboe@kernel.dk" <axboe@kernel.dk>
Cc: "bvanassche@acm.org" <bvanassche@acm.org>,
"hch@lst.de" <hch@lst.de>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] block: simplify blksize_bits() implementation
Date: Mon, 31 Oct 2022 02:03:48 +0000 [thread overview]
Message-ID: <a3c2674b-c2fd-9128-4ea0-0264c0fc1156@nvidia.com> (raw)
In-Reply-To: <TYCP286MB23238842958D7C083D6B67CECA349@TYCP286MB2323.JPNP286.PROD.OUTLOOK.COM>
On 10/29/2022 10:20 PM, Dawei Li wrote:
> Convert current looping-based implementation into bit operation,
> which can bring improvement for:
>
> 1) bitops is more efficient for its arch-level optimization.
>
do you have a quantitative date to prove that ?
Also which arch benefits the most ? is it true for all ?
> 2) Given that blksize_bits() is inline, _if_ @size is compile-time
> constant, it's possible that order_base_2() _may_ make output
> compile-time evaluated, depending on code context and compiler behavior.
>
patches like this needs to be supported by the quantitative
data, else I've seen reviewers taking an objection ...
either way :-
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
next prev parent reply other threads:[~2022-10-31 2:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-30 5:20 Dawei Li
2022-10-30 7:36 ` Christoph Hellwig
2022-10-30 14:34 ` Bart Van Assche
2022-10-31 2:03 ` Chaitanya Kulkarni [this message]
2022-10-31 13:27 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a3c2674b-c2fd-9128-4ea0-0264c0fc1156@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=set_pte_at@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®