mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>
Cc: Rob Herring <robh+dt@kernel.org>,
	devicetree@vger.kernel.org, Lee Jones <lee@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	linux-spi@vger.kernel.org,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
	Mark Brown <broonie@kernel.org>,
	openbmc@lists.ozlabs.org
Subject: Re: [PATCH 3/8] dt-bindings: spi: Add Nuvoton WPCM450 Flash Interface Unit (FIU)
Date: Sun, 06 Nov 2022 07:27:07 -0600	[thread overview]
Message-ID: <166774077447.2683568.10429527253386553094.robh@kernel.org> (raw)
In-Reply-To: <20221105185911.1547847-4-j.neuschaefer@gmx.net>


On Sat, 05 Nov 2022 19:59:06 +0100, Jonathan Neuschäfer wrote:
> The Flash Interface Unit (FIU) is the SPI flash controller in the
> Nuvoton WPCM450 BMC SoC. It supports four chip selects, and direct
> (memory-mapped) access to 16 MiB per chip. Larger flash chips can be
> accessed by software-defined SPI transfers.
> 
> The FIU in newer NPCM7xx SoCs is not compatible with the WPCM450 FIU.
> 
> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
> ---
>  .../bindings/spi/nuvoton,wpcm450-fiu.yaml     | 76 +++++++++++++++++++
>  1 file changed, 76 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/spi/nuvoton,wpcm450-fiu.yaml
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/spi/nuvoton,wpcm450-fiu.example.dts:18:18: fatal error: dt-bindings/clock/nuvoton,wpcm450-clk.h: No such file or directory
   18 |         #include <dt-bindings/clock/nuvoton,wpcm450-clk.h>
      |                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[1]: *** [scripts/Makefile.lib:406: Documentation/devicetree/bindings/spi/nuvoton,wpcm450-fiu.example.dtb] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:1492: dt_binding_check] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/patch/

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.


  parent reply	other threads:[~2022-11-06 13:27 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-05 18:59 [PATCH 0/8] Nuvoton WPCM450 FIU SPI flash controller Jonathan Neuschäfer
2022-11-05 18:59 ` [PATCH 1/8] pinctrl: nuvoton: wpcm450: Refactor MFSEL setting code Jonathan Neuschäfer
2022-11-05 18:59 ` [PATCH 2/8] pinctrl: nuvoton: wpcm450: Fix handling of inverted MFSEL bits Jonathan Neuschäfer
2022-11-05 18:59 ` [PATCH 3/8] dt-bindings: spi: Add Nuvoton WPCM450 Flash Interface Unit (FIU) Jonathan Neuschäfer
2022-11-06  9:38   ` Krzysztof Kozlowski
2022-11-06 14:45     ` Jonathan Neuschäfer
2022-11-07  8:09       ` Krzysztof Kozlowski
2022-11-07 12:12         ` Jonathan Neuschäfer
2022-11-06 13:27   ` Rob Herring [this message]
2022-11-05 18:59 ` [PATCH 4/8] dt-bindings: mfd: syscon: Add nuvoton,wpcm450-shm Jonathan Neuschäfer
2022-11-06  9:39   ` Krzysztof Kozlowski
2022-11-07  9:20   ` Lee Jones
2022-11-05 18:59 ` [PATCH 5/8] ARM: dts: wpcm450: Add FIU SPI controller node Jonathan Neuschäfer
2022-11-05 18:59 ` [PATCH 6/8] ARM: dts: wpcm450-supermicro-x9sci-ln4f: Add SPI flash Jonathan Neuschäfer
2022-11-05 18:59 ` [PATCH 7/8] spi: wpcm-fiu: Add driver for Nuvoton WPCM450 Flash Interface Unit (FIU) Jonathan Neuschäfer
2022-11-05 21:35   ` kernel test robot
2022-11-06 14:51     ` Jonathan Neuschäfer
2022-11-05 21:45   ` kernel test robot
2022-11-05 18:59 ` [PATCH 8/8] spi: wpcm-fiu: Add direct map support Jonathan Neuschäfer
2022-11-05 21:35   ` kernel test robot
2022-11-06 14:49     ` Jonathan Neuschäfer
2022-11-09  8:41 ` [PATCH 0/8] Nuvoton WPCM450 FIU SPI flash controller Linus Walleij
2022-11-09 10:08   ` Jonathan Neuschäfer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=166774077447.2683568.10429527253386553094.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=j.neuschaefer@gmx.net \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=lee@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=openbmc@lists.ozlabs.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®