mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] x86/traps: Fix duplicate included asm/proto.h
@ 2021-05-13 10:46 Jiapeng Chong
  2022-11-08 21:35 ` [tip: x86/cleanups] x86: Fix misc small issues tip-bot2 for Jiapeng Chong
  0 siblings, 1 reply; 2+ messages in thread
From: Jiapeng Chong @ 2021-05-13 10:46 UTC (permalink / raw)
  To: tglx; +Cc: mingo, bp, x86, hpa, linux-kernel, Jiapeng Chong

Clean up the following includecheck warning:

./arch/x86/kernel/traps.c: asm/proto.h is included more than once.

No functional change.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
 arch/x86/kernel/traps.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kernel/traps.c b/arch/x86/kernel/traps.c
index 853ea7a..c4710e7 100644
--- a/arch/x86/kernel/traps.c
+++ b/arch/x86/kernel/traps.c
@@ -64,13 +64,13 @@
 
 #ifdef CONFIG_X86_64
 #include <asm/x86_init.h>
-#include <asm/proto.h>
 #else
 #include <asm/processor-flags.h>
 #include <asm/setup.h>
-#include <asm/proto.h>
 #endif
 
+#include <asm/proto.h>
+
 DECLARE_BITMAP(system_vectors, NR_VECTORS);
 
 static inline void cond_local_irq_enable(struct pt_regs *regs)
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* [tip: x86/cleanups] x86: Fix misc small issues
  2021-05-13 10:46 [PATCH] x86/traps: Fix duplicate included asm/proto.h Jiapeng Chong
@ 2022-11-08 21:35 ` tip-bot2 for Jiapeng Chong
  0 siblings, 0 replies; 2+ messages in thread
From: tip-bot2 for Jiapeng Chong @ 2022-11-08 21:35 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: Abaci Robot, Jiapeng Chong, Borislav Petkov, x86, linux-kernel

The following commit has been merged into the x86/cleanups branch of tip:

Commit-ID:     6426773410fd829c15b59575afe531d66abc7201
Gitweb:        https://git.kernel.org/tip/6426773410fd829c15b59575afe531d66abc7201
Author:        Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
AuthorDate:    Tue, 08 Nov 2022 22:09:51 +01:00
Committer:     Borislav Petkov <bp@suse.de>
CommitterDate: Tue, 08 Nov 2022 22:16:08 +01:00

x86: Fix misc small issues

Fix:

  ./arch/x86/kernel/traps.c: asm/proto.h is included more than once.

  ./arch/x86/kernel/alternative.c:1610:2-3: Unneeded semicolon.

  [ bp: Merge into a single patch. ]

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Link: https://lore.kernel.org/r/1620902768-53822-1-git-send-email-jiapeng.chong@linux.alibaba.com
Link: https://lore.kernel.org/r/20220926054628.116957-1-jiapeng.chong@linux.alibaba.com
---
 arch/x86/kernel/alternative.c | 2 +-
 arch/x86/kernel/traps.c       | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/x86/kernel/alternative.c b/arch/x86/kernel/alternative.c
index 5cadcea..d5f1e13 100644
--- a/arch/x86/kernel/alternative.c
+++ b/arch/x86/kernel/alternative.c
@@ -1608,7 +1608,7 @@ static void text_poke_loc_init(struct text_poke_loc *tp, void *addr,
 
 	default:
 		BUG_ON(len != insn.length);
-	};
+	}
 
 
 	switch (tp->opcode) {
diff --git a/arch/x86/kernel/traps.c b/arch/x86/kernel/traps.c
index 178015a..c3bff64 100644
--- a/arch/x86/kernel/traps.c
+++ b/arch/x86/kernel/traps.c
@@ -67,13 +67,13 @@
 
 #ifdef CONFIG_X86_64
 #include <asm/x86_init.h>
-#include <asm/proto.h>
 #else
 #include <asm/processor-flags.h>
 #include <asm/setup.h>
-#include <asm/proto.h>
 #endif
 
+#include <asm/proto.h>
+
 DECLARE_BITMAP(system_vectors, NR_VECTORS);
 
 static inline void cond_local_irq_enable(struct pt_regs *regs)

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-11-08 21:35 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-13 10:46 [PATCH] x86/traps: Fix duplicate included asm/proto.h Jiapeng Chong
2022-11-08 21:35 ` [tip: x86/cleanups] x86: Fix misc small issues tip-bot2 for Jiapeng Chong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®