* [PATCH] mISDN: fix misuse of put_device() in mISDN_register_device()
@ 2022-11-10 11:38 Wang ShaoBo
2022-11-14 10:50 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Wang ShaoBo @ 2022-11-10 11:38 UTC (permalink / raw)
Cc: isdn, davem, netdev, liwei391, linux-kernel
We should not release reference by put_device() before calling device_initialize().
Fixes: e7d1d4d9ac0d ("mISDN: fix possible memory leak in mISDN_register_device()")
Signed-off-by: Wang ShaoBo <bobo.shaobowang@huawei.com>
---
drivers/isdn/mISDN/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/isdn/mISDN/core.c b/drivers/isdn/mISDN/core.c
index 7ea0100f218a..90ee56d07a6e 100644
--- a/drivers/isdn/mISDN/core.c
+++ b/drivers/isdn/mISDN/core.c
@@ -222,7 +222,7 @@ mISDN_register_device(struct mISDNdevice *dev,
err = get_free_devid();
if (err < 0)
- goto error1;
+ return err;
dev->id = err;
device_initialize(&dev->dev);
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] mISDN: fix misuse of put_device() in mISDN_register_device()
2022-11-10 11:38 [PATCH] mISDN: fix misuse of put_device() in mISDN_register_device() Wang ShaoBo
@ 2022-11-14 10:50 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-11-14 10:50 UTC (permalink / raw)
To: Wang ShaoBo; +Cc: isdn, davem, netdev, liwei391, linux-kernel
Hello:
This patch was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:
On Thu, 10 Nov 2022 19:38:23 +0800 you wrote:
> We should not release reference by put_device() before calling device_initialize().
>
> Fixes: e7d1d4d9ac0d ("mISDN: fix possible memory leak in mISDN_register_device()")
> Signed-off-by: Wang ShaoBo <bobo.shaobowang@huawei.com>
> ---
> drivers/isdn/mISDN/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Here is the summary with links:
- mISDN: fix misuse of put_device() in mISDN_register_device()
https://git.kernel.org/netdev/net/c/2d25107e111a
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-11-14 10:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-10 11:38 [PATCH] mISDN: fix misuse of put_device() in mISDN_register_device() Wang ShaoBo
2022-11-14 10:50 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome