* [PATCH v2 2/4] dt-bindings: soc: samsung: exynos-sysreg: split from syscon
2022-11-27 12:32 [PATCH v2 1/4] arm64: dts: exynos: add dedicated SYSREG compatibles to Exynos5433 Krzysztof Kozlowski
@ 2022-11-27 12:32 ` Krzysztof Kozlowski
2022-12-01 21:50 ` Rob Herring
2022-11-27 12:32 ` [PATCH v2 3/4] dt-bindings: soc: samsung: exynos-sysreg: add dedicated SYSREG compatibles to Exynos5433 Krzysztof Kozlowski
` (2 subsequent siblings)
3 siblings, 1 reply; 9+ messages in thread
From: Krzysztof Kozlowski @ 2022-11-27 12:32 UTC (permalink / raw)
To: Lee Jones, Rob Herring, Krzysztof Kozlowski, Alim Akhtar,
devicetree, linux-kernel, linux-arm-kernel, linux-samsung-soc
Cc: Krzysztof Kozlowski, Sam Protsenko, Sriranjani P, Chanho Park
Split Samsung Exynos SoC SYSREG bindings to own file to narrow the
bindings and do not allow other parts of syscon.yaml. This allows
further customization of Samsung SoC bindings.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Acked-by: Lee Jones <lee@kernel.org>
Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org>
Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
Reviewed-by: Sriranjani P <sriranjani.p@samsung.com>
---
Changes since v1:
1. Add Rb tags.
Cc: Sriranjani P <sriranjani.p@samsung.com>
Cc: Chanho Park <chanho61.park@samsung.com>
Cc: Sam Protsenko <semen.protsenko@linaro.org>
---
.../devicetree/bindings/mfd/syscon.yaml | 6 ---
.../soc/samsung/samsung,exynos-sysreg.yaml | 39 +++++++++++++++++++
2 files changed, 39 insertions(+), 6 deletions(-)
create mode 100644 Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml
index 1b01bd010431..b73ba1ea08f7 100644
--- a/Documentation/devicetree/bindings/mfd/syscon.yaml
+++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
@@ -64,12 +64,6 @@ properties:
- rockchip,rk3568-qos
- rockchip,rk3588-qos
- rockchip,rv1126-qos
- - samsung,exynos3-sysreg
- - samsung,exynos4-sysreg
- - samsung,exynos5-sysreg
- - samsung,exynos5433-sysreg
- - samsung,exynos850-sysreg
- - samsung,exynosautov9-sysreg
- const: syscon
diff --git a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
new file mode 100644
index 000000000000..68064a5e339c
--- /dev/null
+++ b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
@@ -0,0 +1,39 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/soc/samsung/samsung,exynos-sysreg.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Samsung Exynos SoC series System Registers (SYSREG)
+
+maintainers:
+ - Krzysztof Kozlowski <krzk@kernel.org>
+
+properties:
+ compatible:
+ oneOf:
+ - items:
+ - enum:
+ - samsung,exynos3-sysreg
+ - samsung,exynos4-sysreg
+ - samsung,exynos5-sysreg
+ - samsung,exynos5433-sysreg
+ - samsung,exynos850-sysreg
+ - samsung,exynosautov9-sysreg
+ - const: syscon
+
+ reg:
+ maxItems: 1
+
+required:
+ - compatible
+ - reg
+
+additionalProperties: false
+
+examples:
+ - |
+ system-controller@10010000 {
+ compatible = "samsung,exynos4-sysreg", "syscon";
+ reg = <0x10010000 0x400>;
+ };
--
2.34.1
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH v2 2/4] dt-bindings: soc: samsung: exynos-sysreg: split from syscon
2022-11-27 12:32 ` [PATCH v2 2/4] dt-bindings: soc: samsung: exynos-sysreg: split from syscon Krzysztof Kozlowski
@ 2022-12-01 21:50 ` Rob Herring
0 siblings, 0 replies; 9+ messages in thread
From: Rob Herring @ 2022-12-01 21:50 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Rob Herring, Lee Jones, linux-kernel, Alim Akhtar, Sam Protsenko,
linux-samsung-soc, Sriranjani P, linux-arm-kernel, Chanho Park,
devicetree, Krzysztof Kozlowski
On Sun, 27 Nov 2022 13:32:57 +0100, Krzysztof Kozlowski wrote:
> Split Samsung Exynos SoC SYSREG bindings to own file to narrow the
> bindings and do not allow other parts of syscon.yaml. This allows
> further customization of Samsung SoC bindings.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Acked-by: Lee Jones <lee@kernel.org>
> Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org>
> Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
> Reviewed-by: Sriranjani P <sriranjani.p@samsung.com>
>
> ---
>
> Changes since v1:
> 1. Add Rb tags.
>
> Cc: Sriranjani P <sriranjani.p@samsung.com>
> Cc: Chanho Park <chanho61.park@samsung.com>
> Cc: Sam Protsenko <semen.protsenko@linaro.org>
> ---
> .../devicetree/bindings/mfd/syscon.yaml | 6 ---
> .../soc/samsung/samsung,exynos-sysreg.yaml | 39 +++++++++++++++++++
> 2 files changed, 39 insertions(+), 6 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2 3/4] dt-bindings: soc: samsung: exynos-sysreg: add dedicated SYSREG compatibles to Exynos5433
2022-11-27 12:32 [PATCH v2 1/4] arm64: dts: exynos: add dedicated SYSREG compatibles to Exynos5433 Krzysztof Kozlowski
2022-11-27 12:32 ` [PATCH v2 2/4] dt-bindings: soc: samsung: exynos-sysreg: split from syscon Krzysztof Kozlowski
@ 2022-11-27 12:32 ` Krzysztof Kozlowski
2022-12-01 21:51 ` Rob Herring
2022-11-27 12:32 ` [PATCH v2 4/4] dt-bindings: soc: samsung: exynos-sysreg: add clocks for Exynos850 Krzysztof Kozlowski
2022-12-26 15:17 ` [PATCH v2 1/4] arm64: dts: exynos: add dedicated SYSREG compatibles to Exynos5433 Krzysztof Kozlowski
3 siblings, 1 reply; 9+ messages in thread
From: Krzysztof Kozlowski @ 2022-11-27 12:32 UTC (permalink / raw)
To: Lee Jones, Rob Herring, Krzysztof Kozlowski, Alim Akhtar,
devicetree, linux-kernel, linux-arm-kernel, linux-samsung-soc
Cc: Krzysztof Kozlowski, Sam Protsenko, Sriranjani P, Chanho Park
Exynos5433 has several different SYSREGs, so use dedicated compatibles
for them and deprecate usage of generic Exynos5433 compatible alone (as
it is too generic).
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org>
Reviewed-by: Sriranjani P <sriranjani.p@samsung.com>
---
Changes since v1:
1. Add Rb tags.
Cc: Sriranjani P <sriranjani.p@samsung.com>
Cc: Chanho Park <chanho61.park@samsung.com>
Cc: Sam Protsenko <semen.protsenko@linaro.org>
---
.../bindings/soc/samsung/samsung,exynos-sysreg.yaml | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
index 68064a5e339c..42357466005e 100644
--- a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
+++ b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
@@ -17,10 +17,21 @@ properties:
- samsung,exynos3-sysreg
- samsung,exynos4-sysreg
- samsung,exynos5-sysreg
- - samsung,exynos5433-sysreg
- samsung,exynos850-sysreg
- samsung,exynosautov9-sysreg
- const: syscon
+ - items:
+ - enum:
+ - samsung,exynos5433-cam0-sysreg
+ - samsung,exynos5433-cam1-sysreg
+ - samsung,exynos5433-disp-sysreg
+ - samsung,exynos5433-fsys-sysreg
+ - const: samsung,exynos5433-sysreg
+ - const: syscon
+ - items:
+ - const: samsung,exynos5433-sysreg
+ - const: syscon
+ deprecated: true
reg:
maxItems: 1
--
2.34.1
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH v2 3/4] dt-bindings: soc: samsung: exynos-sysreg: add dedicated SYSREG compatibles to Exynos5433
2022-11-27 12:32 ` [PATCH v2 3/4] dt-bindings: soc: samsung: exynos-sysreg: add dedicated SYSREG compatibles to Exynos5433 Krzysztof Kozlowski
@ 2022-12-01 21:51 ` Rob Herring
0 siblings, 0 replies; 9+ messages in thread
From: Rob Herring @ 2022-12-01 21:51 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Sam Protsenko, Lee Jones, linux-samsung-soc, Krzysztof Kozlowski,
Alim Akhtar, linux-arm-kernel, Chanho Park, devicetree,
Sriranjani P, Rob Herring, linux-kernel
On Sun, 27 Nov 2022 13:32:58 +0100, Krzysztof Kozlowski wrote:
> Exynos5433 has several different SYSREGs, so use dedicated compatibles
> for them and deprecate usage of generic Exynos5433 compatible alone (as
> it is too generic).
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org>
> Reviewed-by: Sriranjani P <sriranjani.p@samsung.com>
>
> ---
>
> Changes since v1:
> 1. Add Rb tags.
>
> Cc: Sriranjani P <sriranjani.p@samsung.com>
> Cc: Chanho Park <chanho61.park@samsung.com>
> Cc: Sam Protsenko <semen.protsenko@linaro.org>
> ---
> .../bindings/soc/samsung/samsung,exynos-sysreg.yaml | 13 ++++++++++++-
> 1 file changed, 12 insertions(+), 1 deletion(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2 4/4] dt-bindings: soc: samsung: exynos-sysreg: add clocks for Exynos850
2022-11-27 12:32 [PATCH v2 1/4] arm64: dts: exynos: add dedicated SYSREG compatibles to Exynos5433 Krzysztof Kozlowski
2022-11-27 12:32 ` [PATCH v2 2/4] dt-bindings: soc: samsung: exynos-sysreg: split from syscon Krzysztof Kozlowski
2022-11-27 12:32 ` [PATCH v2 3/4] dt-bindings: soc: samsung: exynos-sysreg: add dedicated SYSREG compatibles to Exynos5433 Krzysztof Kozlowski
@ 2022-11-27 12:32 ` Krzysztof Kozlowski
2022-11-27 15:43 ` Sam Protsenko
2022-12-01 21:51 ` Rob Herring
2022-12-26 15:17 ` [PATCH v2 1/4] arm64: dts: exynos: add dedicated SYSREG compatibles to Exynos5433 Krzysztof Kozlowski
3 siblings, 2 replies; 9+ messages in thread
From: Krzysztof Kozlowski @ 2022-11-27 12:32 UTC (permalink / raw)
To: Lee Jones, Rob Herring, Krzysztof Kozlowski, Alim Akhtar,
devicetree, linux-kernel, linux-arm-kernel, linux-samsung-soc
Cc: Krzysztof Kozlowski, Sriranjani P, Chanho Park, Sam Protsenko
Exynos850 has dedicated clock for accessing SYSREGs. Allow it, even
though Linux currently does not enable them and relies on bootloader.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Changes since v1:
1. Make clocks required on Exynos850.
2. Due to above change, do not add Rb tags.
Cc: Sriranjani P <sriranjani.p@samsung.com>
Cc: Chanho Park <chanho61.park@samsung.com>
Cc: Sam Protsenko <semen.protsenko@linaro.org>
---
.../soc/samsung/samsung,exynos-sysreg.yaml | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
index 42357466005e..9f3fc6406d9d 100644
--- a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
+++ b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
@@ -36,10 +36,27 @@ properties:
reg:
maxItems: 1
+ clocks:
+ maxItems: 1
+
required:
- compatible
- reg
+allOf:
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - samsung,exynos850-sysreg
+ then:
+ required:
+ - clocks
+ else:
+ properties:
+ clocks: false
+
additionalProperties: false
examples:
--
2.34.1
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH v2 4/4] dt-bindings: soc: samsung: exynos-sysreg: add clocks for Exynos850
2022-11-27 12:32 ` [PATCH v2 4/4] dt-bindings: soc: samsung: exynos-sysreg: add clocks for Exynos850 Krzysztof Kozlowski
@ 2022-11-27 15:43 ` Sam Protsenko
2022-12-01 21:51 ` Rob Herring
1 sibling, 0 replies; 9+ messages in thread
From: Sam Protsenko @ 2022-11-27 15:43 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Lee Jones, Rob Herring, Krzysztof Kozlowski, Alim Akhtar,
devicetree, linux-kernel, linux-arm-kernel, linux-samsung-soc,
Sriranjani P, Chanho Park
On Sun, 27 Nov 2022 at 06:33, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> Exynos850 has dedicated clock for accessing SYSREGs. Allow it, even
> though Linux currently does not enable them and relies on bootloader.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> Changes since v1:
> 1. Make clocks required on Exynos850.
> 2. Due to above change, do not add Rb tags.
>
> Cc: Sriranjani P <sriranjani.p@samsung.com>
> Cc: Chanho Park <chanho61.park@samsung.com>
> Cc: Sam Protsenko <semen.protsenko@linaro.org>
> ---
Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org>
> .../soc/samsung/samsung,exynos-sysreg.yaml | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
> index 42357466005e..9f3fc6406d9d 100644
> --- a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
> +++ b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
> @@ -36,10 +36,27 @@ properties:
> reg:
> maxItems: 1
>
> + clocks:
> + maxItems: 1
> +
> required:
> - compatible
> - reg
>
> +allOf:
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - samsung,exynos850-sysreg
> + then:
> + required:
> + - clocks
> + else:
> + properties:
> + clocks: false
> +
> additionalProperties: false
>
> examples:
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 4/4] dt-bindings: soc: samsung: exynos-sysreg: add clocks for Exynos850
2022-11-27 12:32 ` [PATCH v2 4/4] dt-bindings: soc: samsung: exynos-sysreg: add clocks for Exynos850 Krzysztof Kozlowski
2022-11-27 15:43 ` Sam Protsenko
@ 2022-12-01 21:51 ` Rob Herring
1 sibling, 0 replies; 9+ messages in thread
From: Rob Herring @ 2022-12-01 21:51 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Krzysztof Kozlowski, devicetree, linux-arm-kernel, Lee Jones,
Alim Akhtar, Chanho Park, Rob Herring, linux-kernel,
Sam Protsenko, linux-samsung-soc, Sriranjani P
On Sun, 27 Nov 2022 13:32:59 +0100, Krzysztof Kozlowski wrote:
> Exynos850 has dedicated clock for accessing SYSREGs. Allow it, even
> though Linux currently does not enable them and relies on bootloader.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> Changes since v1:
> 1. Make clocks required on Exynos850.
> 2. Due to above change, do not add Rb tags.
>
> Cc: Sriranjani P <sriranjani.p@samsung.com>
> Cc: Chanho Park <chanho61.park@samsung.com>
> Cc: Sam Protsenko <semen.protsenko@linaro.org>
> ---
> .../soc/samsung/samsung,exynos-sysreg.yaml | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 1/4] arm64: dts: exynos: add dedicated SYSREG compatibles to Exynos5433
2022-11-27 12:32 [PATCH v2 1/4] arm64: dts: exynos: add dedicated SYSREG compatibles to Exynos5433 Krzysztof Kozlowski
` (2 preceding siblings ...)
2022-11-27 12:32 ` [PATCH v2 4/4] dt-bindings: soc: samsung: exynos-sysreg: add clocks for Exynos850 Krzysztof Kozlowski
@ 2022-12-26 15:17 ` Krzysztof Kozlowski
3 siblings, 0 replies; 9+ messages in thread
From: Krzysztof Kozlowski @ 2022-12-26 15:17 UTC (permalink / raw)
To: Lee Jones, Krzysztof Kozlowski, Alim Akhtar, linux-samsung-soc,
devicetree, linux-kernel, linux-arm-kernel, Krzysztof Kozlowski,
Rob Herring
Cc: Sam Protsenko, Sriranjani P, Chanho Park
On Sun, 27 Nov 2022 13:32:56 +0100, Krzysztof Kozlowski wrote:
> Exynos5433 has several different SYSREGs, so use dedicated compatibles
> for them.
>
>
Applied, thanks!
[1/4] arm64: dts: exynos: add dedicated SYSREG compatibles to Exynos5433
https://git.kernel.org/krzk/linux/c/c514239c4f3d0e5d0eb2be9adbd1992702647e76
[2/4] dt-bindings: soc: samsung: exynos-sysreg: split from syscon
https://git.kernel.org/krzk/linux/c/c2e322ae9f06be31ab5db1f29630f81469a37d75
[3/4] dt-bindings: soc: samsung: exynos-sysreg: add dedicated SYSREG compatibles to Exynos5433
https://git.kernel.org/krzk/linux/c/7b35b6b8aab2fd4249fe2828f108e88e9279eadd
[4/4] dt-bindings: soc: samsung: exynos-sysreg: add clocks for Exynos850
https://git.kernel.org/krzk/linux/c/af7354c7c02249276ceb3011eecddd469246b2bf
Best regards,
--
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
^ permalink raw reply [flat|nested] 9+ messages in thread