mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Wang YanQing <udknight@gmail.com>, Joe Perches <joe@perches.com>,
	Andy Whitcroft <apw@canonical.com>,
	kernel-janitors@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
	Alexei Starovoitov <alexei.starovoitov@gmail.com>,
	Matteo Croce <mcroce@redhat.com>
Subject: Re: [v3] checkpatch: add dedicated checker for 'Fixes:' tag
Date: Tue, 28 Apr 2020 16:54:13 +0200	[thread overview]
Message-ID: <166ad4b2-5c27-9027-6eef-83d0faef4d1b@web.de> (raw)
In-Reply-To: <20200428140649.GA30042@udknight>

> I guess it is a better perl programming practice that use non-capturing group always

I suggest to reconsider the information “always”.


> when you don't need to use the '$' to access it,

Such an expectation can be fine if alternatives would be specified in
the notation “(?:…)”.


> it will make code a little faster I guess.

I hope this also when such a specification is actually needed.


>> * Would we like to support any other quotation characters around
>>   the commit summary?
>
> I think we don't need now

I propose to reconsider also this view.
How should titles be safely handled if they contain the mentioned
quotation characters?

Can it be that you are used to the application of a specific language
where you should choose between two quotes for specification
of attributes (or text)?


> and people could patch it easily when we need others in future:)

I guess that there are further software development challenges to consider.
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/scripts/checkpatch.pl?id=b240f960afb900e59112ebcfa5a759bb0a85a14e#n2872

Regards,
Markus

  reply	other threads:[~2020-04-28 14:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-28  2:02 [PATCH v3] " Wang YanQing
2020-04-28  6:21 ` Markus Elfring
2020-04-28 14:06   ` Wang YanQing
2020-04-28 14:54     ` Markus Elfring [this message]
2020-04-28 10:52 ` Markus Elfring
2020-04-28 16:18   ` Wang YanQing
2020-04-29 15:18     ` [v3] " Markus Elfring
2020-04-28 16:10 ` [PATCH v3] " Joe Perches
2020-04-28 23:17   ` Joe Perches
2020-04-29  6:45     ` [v3] " Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=166ad4b2-5c27-9027-6eef-83d0faef4d1b@web.de \
    --to=markus.elfring@web.de \
    --cc=alexei.starovoitov@gmail.com \
    --cc=apw@canonical.com \
    --cc=joe@perches.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mcroce@redhat.com \
    --cc=udknight@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®