From: Joe Perches <joe@perches.com>
To: Wang YanQing <udknight@gmail.com>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Alexei Starovoitov <alexei.starovoitov@gmail.com>,
Andy Whitcroft <apw@canonical.com>,
Markus.Elfring@web.de, mcroce@redhat.com
Subject: Re: [PATCH v3] checkpatch: add dedicated checker for 'Fixes:' tag
Date: Tue, 28 Apr 2020 16:17:03 -0700 [thread overview]
Message-ID: <a2d7dbae193800ce430321d3fcc71ab5d1a5ed03.camel@perches.com> (raw)
In-Reply-To: <b452dc29fb553fa5993b90131dcdbc04ed87532e.camel@perches.com>
On Tue, 2020-04-28 at 09:10 -0700, Joe Perches wrote:
> On Tue, 2020-04-28 at 10:02 +0800, Wang YanQing wrote:
> > According to submitting-patches.rst, 'Fixes:' tag has a little
> > stricter condition about the one line summary:
> > ...
> > Do not split the tag across multiple
> > lines, tags are exempt from the "wrap at 75 columns" rule in order to simplify
> > parsing scripts
> > ...
> >
> > And there is no 'Fixes:' tag format checker in checkpatch to check
> > the commit id length too, so let's add dedicated checker to check
> > these conditions for 'Fixes:' tag.
>
> There's no need to duplicate functionality like this.
> Put this additional Fixes: logic into the existing block.
>
> (and don't take advise from Markus too seriously when it
> comes to English grammar or wording. He is not an arbiter
> of taste for this code)
>
btw: I suggested this patch last year.
https://lore.kernel.org/lkml/40bfc40958fca6e2cc9b86101153aa0715fac4f7.camel@perches.com/
next prev parent reply other threads:[~2020-04-28 23:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-28 2:02 Wang YanQing
2020-04-28 6:21 ` Markus Elfring
2020-04-28 14:06 ` Wang YanQing
2020-04-28 14:54 ` [v3] " Markus Elfring
2020-04-28 10:52 ` [PATCH v3] " Markus Elfring
2020-04-28 16:18 ` Wang YanQing
2020-04-29 15:18 ` [v3] " Markus Elfring
2020-04-28 16:10 ` [PATCH v3] " Joe Perches
2020-04-28 23:17 ` Joe Perches [this message]
2020-04-29 6:45 ` [v3] " Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a2d7dbae193800ce430321d3fcc71ab5d1a5ed03.camel@perches.com \
--to=joe@perches.com \
--cc=Markus.Elfring@web.de \
--cc=alexei.starovoitov@gmail.com \
--cc=apw@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcroce@redhat.com \
--cc=udknight@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®