mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Manjunatha Venkatesh <manjunatha.venkatesh@nxp.com>
Cc: axboe@kernel.dk, sunilmut@microsoft.com, jasowang@redhat.com,
	will@kernel.org, linux-kernel@vger.kernel.org,
	robh+dt@kernel.org, rvmanjumce@gmail.com,
	krzysztof.kozlowski+dt@linaro.org, mst@redhat.com,
	Kwame Adwere <kwame.adwere@nxp.com>,
	ashish.deshpande@nxp.com, arnd@arndb.d,
	gregkh@linuxfoundation.org, mikelley@microsoft.com,
	javier@javigon.com, mb@lightnvm.io, devicetree@vger.kernel.org,
	ckeepax@opensource.cirrus.com, bjorn.andersson@linaro.org
Subject: Re: [PATCH v6 1/2] dt-bindings: uwb: Device tree information for Nxp SR1XX SOCs
Date: Tue, 20 Dec 2022 10:40:56 -0600	[thread overview]
Message-ID: <167155421014.690186.2937416148656776999.robh@kernel.org> (raw)
In-Reply-To: <20221220154747.2372597-2-manjunatha.venkatesh@nxp.com>


On Tue, 20 Dec 2022 21:17:46 +0530, Manjunatha Venkatesh wrote:
> Ultra-wideband (UWB) is a short-range wireless communication protocol.
> 
> NXP has SR1XX family of UWB Subsystems (UWBS) devices. SR1XX SOCs
> are FiRa Compliant. SR1XX SOCs are flash less devices and they need
> Firmware Download on every device boot. More details on the SR1XX Family
> can be found at https://www.nxp.com/products/:UWB-TRIMENSION
> 
> The sr1xx driver work the SR1XX Family of UWBS, and uses UWB Controller
> Interface (UCI).  The corresponding details are available in the FiRa
> Consortium Website (https://www.firaconsortium.org/).
> 
> Link: https://lore.kernel.org/r/425858dc-59fe-2311-61ae-3b6dc77a2576@nxp.com
> Signed-off-by: Manjunatha Venkatesh <manjunatha.venkatesh@nxp.com>
> Signed-off-by: Kwame Adwere <kwame.adwere@nxp.com>
> ---
> Changes since v5:
>   - Moved ioctl command definitions into header file.
>   - Version 5 patch review comments addressed.
>   - Corporate lawyer sign-off updated.
> 
>  .../bindings/uwb/nxp,uwb-sr1xx.yaml           | 65 +++++++++++++++++++
>  1 file changed, 65 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/uwb/nxp,uwb-sr1xx.yaml
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:
./Documentation/devicetree/bindings/uwb/nxp,uwb-sr1xx.yaml:8:8: [warning] too many spaces after colon (colons)

dtschema/dtc warnings/errors:
Error: Documentation/devicetree/bindings/uwb/nxp,uwb-sr1xx.example.dts:31.31-32 syntax error
FATAL ERROR: Unable to parse input tree
make[1]: *** [scripts/Makefile.lib:406: Documentation/devicetree/bindings/uwb/nxp,uwb-sr1xx.example.dtb] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:1492: dt_binding_check] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20221220154747.2372597-2-manjunatha.venkatesh@nxp.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


  parent reply	other threads:[~2022-12-20 16:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-20 15:47 [PATCH v6 0/2]Uwb: Nxp: Driver for SR1XX SOCs Patch Series Manjunatha Venkatesh
2022-12-20 15:47 ` [PATCH v6 1/2] dt-bindings: uwb: Device tree information for Nxp SR1XX SOCs Manjunatha Venkatesh
2022-12-20 15:56   ` Krzysztof Kozlowski
2022-12-20 16:40   ` Rob Herring [this message]
2022-12-20 15:47 ` [PATCH v6 2/2] misc: nxp-sr1xx: UWB driver support for sr1xx series chip Manjunatha Venkatesh
2022-12-20 15:58   ` Krzysztof Kozlowski
2022-12-21  6:12   ` Greg KH
2023-09-25 13:51     ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=167155421014.690186.2937416148656776999.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=arnd@arndb.d \
    --cc=ashish.deshpande@nxp.com \
    --cc=axboe@kernel.dk \
    --cc=bjorn.andersson@linaro.org \
    --cc=ckeepax@opensource.cirrus.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jasowang@redhat.com \
    --cc=javier@javigon.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=kwame.adwere@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manjunatha.venkatesh@nxp.com \
    --cc=mb@lightnvm.io \
    --cc=mikelley@microsoft.com \
    --cc=mst@redhat.com \
    --cc=robh+dt@kernel.org \
    --cc=rvmanjumce@gmail.com \
    --cc=sunilmut@microsoft.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®