mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Javier Martinez Canillas <javierm@redhat.com>
Cc: "Maya Matuszczyk" <maccraft123mc@gmail.com>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
	"Martijn Braam" <martijn@brixit.nl>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"Tom Fitzhenry" <tom@tom-fitzhenry.me.uk>,
	"David Airlie" <airlied@gmail.com>,
	"Thierry Reding" <thierry.reding@gmail.com>,
	"Kamil Trzciński" <ayufan@ayufan.eu>,
	"Sam Ravnborg" <sam@ravnborg.org>,
	linux-kernel@vger.kernel.org,
	"Peter Robinson" <pbrobinson@gmail.com>,
	devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org,
	"Ondrej Jirman" <megi@xff.cz>,
	"Robert Mader" <robert.mader@posteo.de>,
	"Rob Herring" <robh+dt@kernel.org>
Subject: Re: [PATCH v2 2/4] dt-bindings: display: Add Himax HX8394 panel controller
Date: Mon, 26 Dec 2022 12:23:46 -0600	[thread overview]
Message-ID: <167207881578.4286.1861963771638185276.robh@kernel.org> (raw)
In-Reply-To: <20221226134909.2822179-3-javierm@redhat.com>


On Mon, 26 Dec 2022 14:49:06 +0100, Javier Martinez Canillas wrote:
> Add device tree bindings for panels based on the Himax HX8394 controller,
> such as the HannStar HSD060BHW4 720x1440 TFT LCD panel that is connected
> through a MIPI-DSI video interface.
> 
> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> 
> Changes in v2:
> - Drop redundant "bindings" in subject (Krzysztof Kozlowski).
> - Drop "device tree bindings" in title (Krzysztof Kozlowski).
> - Put port next to other "true" properties (Krzysztof Kozlowski).
> - Add Krzysztof Kozlowski's Reviewed-by tag.
> 
>  .../bindings/display/panel/himax,hx8394.yaml  | 65 +++++++++++++++++++
>  1 file changed, 65 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/panel/himax,hx8394.yaml
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/panel/himax,hx8394.example.dtb: panel@0: 'port' is a required property
	From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/panel/himax,hx8394.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/panel/himax,hx8394.example.dtb: panel@0: 'reg' does not match any of the regexes: 'pinctrl-[0-9]+'
	From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/panel/himax,hx8394.yaml

doc reference errors (make refcheckdocs):


See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20221226134909.2822179-3-javierm@redhat.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


  reply	other threads:[~2022-12-26 22:37 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-26 13:49 [PATCH v2 0/4] Add PinePhone Pro display support Javier Martinez Canillas
2022-12-26 13:49 ` [PATCH v2 1/4] drm: panel: Add Himax HX8394 panel controller driver Javier Martinez Canillas
2022-12-26 15:05   ` Sam Ravnborg
2022-12-26 16:43     ` Javier Martinez Canillas
2022-12-26 13:49 ` [PATCH v2 2/4] dt-bindings: display: Add Himax HX8394 panel controller Javier Martinez Canillas
2022-12-26 18:23   ` Rob Herring [this message]
2022-12-27  7:44   ` Krzysztof Kozlowski
2022-12-27 10:46     ` Javier Martinez Canillas
2022-12-26 13:49 ` [PATCH v2 3/4] MAINTAINERS: Add entry for Himax HX8394 panel controller driver Javier Martinez Canillas
2022-12-26 13:49 ` [PATCH v2 4/4] arm64: dts: rk3399-pinephone-pro: Add internal display support Javier Martinez Canillas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=167207881578.4286.1861963771638185276.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=airlied@gmail.com \
    --cc=ayufan@ayufan.eu \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=javierm@redhat.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maccraft123mc@gmail.com \
    --cc=martijn@brixit.nl \
    --cc=megi@xff.cz \
    --cc=pbrobinson@gmail.com \
    --cc=robert.mader@posteo.de \
    --cc=robh+dt@kernel.org \
    --cc=sam@ravnborg.org \
    --cc=thierry.reding@gmail.com \
    --cc=tom@tom-fitzhenry.me.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®