From: Javier Martinez Canillas <javierm@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: "Ondrej Jirman" <megi@xff.cz>,
"Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
"Robert Mader" <robert.mader@posteo.de>,
"Sam Ravnborg" <sam@ravnborg.org>,
"Maya Matuszczyk" <maccraft123mc@gmail.com>,
"Kamil Trzciński" <ayufan@ayufan.eu>,
"Martijn Braam" <martijn@brixit.nl>,
"Peter Robinson" <pbrobinson@gmail.com>,
"Tom Fitzhenry" <tom@tom-fitzhenry.me.uk>,
"Javier Martinez Canillas" <javierm@redhat.com>,
"Daniel Vetter" <daniel@ffwll.ch>,
"David Airlie" <airlied@gmail.com>,
"Heiko Stuebner" <heiko@sntech.de>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Thierry Reding" <thierry.reding@gmail.com>,
devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org
Subject: [PATCH v2 0/4] Add PinePhone Pro display support
Date: Mon, 26 Dec 2022 14:49:04 +0100 [thread overview]
Message-ID: <20221226134909.2822179-1-javierm@redhat.com> (raw)
This series add support for the display present in the PinePhone Pro.
Patch #1 adds a driver for panels using the Himax HX8394 panel controller,
such as the HSD060BHW4 720x1440 TFT LCD panel present in the PinePhone Pro.
Patch #2 adds a devicetree binding schema for this driver and patch #3 adds
an entry for the driver in the MAINTAINERS file.
Finally patch #4 adds the needed devicetree nodes in the PinePhone Pro DTS,
to enable both the display and the touchscreen. This makes the upstream DTS
much more usable and will allow for example to enable support for the phone
in the Fedora distribution.
I only added myself as the maintainer for the driver because I don't know
if Kamil and Ondrej that worked in the driver would be interested. Please
let me know folks if you are, and I can add you too in the next revision.
This is a v2 of the patch-set that addresses issues pointed out in v1:
https://lore.kernel.org/all/20221222223830.2494900-1-javierm@redhat.com/T/#m692655a06093fe8df0d8748b3df338e57494af2a
The patches were tested on a PinePhone Pro Explorer Edition using a Fedora
37 Workstation image.
Best regards,
Javier
Changes in v2:
- Add year to driver's copyright notice (Sam Ravnborg)
- Remove unused <video/display_timing.h> header include (Sam Ravnborg).
- Use mipi_dsi_dcs_write_seq() helper and drop custom macro (Sam Ravnborg).
- Drop unnecessary info messages and move useful one to debug (Sam Ravnborg).
- Drop redundant "bindings" in subject (Krzysztof Kozlowski).
- Drop "device tree bindings" in title (Krzysztof Kozlowski).
- Put port next to other "true" properties (Krzysztof Kozlowski).
- Add Krzysztof Kozlowski's Reviewed-by tag.
- Fix regulator node names (Maya Matuszczyk).
- Drop non-existent "poweroff-in-suspend" property (Maya Matuszczyk).
- Remove unnecessary comments in panel node (Maya Matuszczyk).
Javier Martinez Canillas (2):
dt-bindings: display: Add Himax HX8394 panel controller
MAINTAINERS: Add entry for Himax HX8394 panel controller driver
Kamil Trzciński (1):
drm: panel: Add Himax HX8394 panel controller driver
Ondrej Jirman (1):
arm64: dts: rk3399-pinephone-pro: Add internal display support
.../bindings/display/panel/himax,hx8394.yaml | 65 +++
MAINTAINERS | 7 +
.../dts/rockchip/rk3399-pinephone-pro.dts | 123 +++++
drivers/gpu/drm/panel/Kconfig | 12 +
drivers/gpu/drm/panel/Makefile | 1 +
drivers/gpu/drm/panel/panel-himax-hx8394.c | 446 ++++++++++++++++++
6 files changed, 654 insertions(+)
create mode 100644 Documentation/devicetree/bindings/display/panel/himax,hx8394.yaml
create mode 100644 drivers/gpu/drm/panel/panel-himax-hx8394.c
--
2.38.1
next reply other threads:[~2022-12-26 13:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-26 13:49 Javier Martinez Canillas [this message]
2022-12-26 13:49 ` [PATCH v2 1/4] drm: panel: Add Himax HX8394 panel controller driver Javier Martinez Canillas
2022-12-26 15:05 ` Sam Ravnborg
2022-12-26 16:43 ` Javier Martinez Canillas
2022-12-26 13:49 ` [PATCH v2 2/4] dt-bindings: display: Add Himax HX8394 panel controller Javier Martinez Canillas
2022-12-26 18:23 ` Rob Herring
2022-12-27 7:44 ` Krzysztof Kozlowski
2022-12-27 10:46 ` Javier Martinez Canillas
2022-12-26 13:49 ` [PATCH v2 3/4] MAINTAINERS: Add entry for Himax HX8394 panel controller driver Javier Martinez Canillas
2022-12-26 13:49 ` [PATCH v2 4/4] arm64: dts: rk3399-pinephone-pro: Add internal display support Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221226134909.2822179-1-javierm@redhat.com \
--to=javierm@redhat.com \
--cc=airlied@gmail.com \
--cc=ayufan@ayufan.eu \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=maccraft123mc@gmail.com \
--cc=martijn@brixit.nl \
--cc=megi@xff.cz \
--cc=pbrobinson@gmail.com \
--cc=robert.mader@posteo.de \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=thierry.reding@gmail.com \
--cc=tom@tom-fitzhenry.me.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®