* [PATCH] dt-bindings: remoteproc: qcom,glink-edge: add GPR node
@ 2022-12-23 13:22 Krzysztof Kozlowski
2022-12-26 21:53 ` Rob Herring
2022-12-27 17:42 ` Bjorn Andersson
0 siblings, 2 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2022-12-23 13:22 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Mathieu Poirier,
Rob Herring, Krzysztof Kozlowski, linux-arm-msm,
linux-remoteproc, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
The existing SM8450 DTS (and newer platforms) come with a "gpr" child node,
not "apr":
sm8450-sony-xperia-nagara-pdx224.dtb: remoteproc@30000000: glink-edge: Unevaluated properties are not allowed ('gpr' was unexpected)
From schema: Documentation/devicetree/bindings/remoteproc/qcom,sm8350-pas.yaml
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
.../bindings/remoteproc/qcom,glink-edge.yaml | 24 ++++++++++++++++++-
1 file changed, 23 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,glink-edge.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,glink-edge.yaml
index 25c27464ef25..8e133ab55ff3 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,glink-edge.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,glink-edge.yaml
@@ -22,7 +22,7 @@ properties:
required:
- qcom,glink-channels
description:
- Qualcomm APR/GPR (Asynchronous/Generic Packet Router)
+ Qualcomm APR (Asynchronous Packet Router)
fastrpc:
$ref: /schemas/misc/qcom,fastrpc.yaml#
@@ -31,6 +31,13 @@ properties:
description:
Qualcomm FastRPC
+ gpr:
+ $ref: /schemas/soc/qcom/qcom,apr.yaml#
+ required:
+ - qcom,glink-channels
+ description:
+ Qualcomm GPR (Generic Packet Router)
+
interrupts:
maxItems: 1
@@ -52,6 +59,21 @@ required:
- mboxes
- qcom,remote-pid
+allOf:
+ - if:
+ required:
+ - apr
+ then:
+ properties:
+ gpr: false
+
+ - if:
+ required:
+ - gpr
+ then:
+ properties:
+ apr: false
+
additionalProperties: false
examples:
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] dt-bindings: remoteproc: qcom,glink-edge: add GPR node
2022-12-23 13:22 [PATCH] dt-bindings: remoteproc: qcom,glink-edge: add GPR node Krzysztof Kozlowski
@ 2022-12-26 21:53 ` Rob Herring
2022-12-27 17:42 ` Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2022-12-26 21:53 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: linux-kernel, linux-remoteproc, linux-arm-msm, Rob Herring,
devicetree, Mathieu Poirier, Krzysztof Kozlowski, Andy Gross,
Bjorn Andersson, Konrad Dybcio
On Fri, 23 Dec 2022 14:22:13 +0100, Krzysztof Kozlowski wrote:
> The existing SM8450 DTS (and newer platforms) come with a "gpr" child node,
> not "apr":
>
> sm8450-sony-xperia-nagara-pdx224.dtb: remoteproc@30000000: glink-edge: Unevaluated properties are not allowed ('gpr' was unexpected)
> From schema: Documentation/devicetree/bindings/remoteproc/qcom,sm8350-pas.yaml
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> .../bindings/remoteproc/qcom,glink-edge.yaml | 24 ++++++++++++++++++-
> 1 file changed, 23 insertions(+), 1 deletion(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] dt-bindings: remoteproc: qcom,glink-edge: add GPR node
2022-12-23 13:22 [PATCH] dt-bindings: remoteproc: qcom,glink-edge: add GPR node Krzysztof Kozlowski
2022-12-26 21:53 ` Rob Herring
@ 2022-12-27 17:42 ` Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2022-12-27 17:42 UTC (permalink / raw)
To: krzysztof.kozlowski+dt, agross, linux-arm-msm, linux-remoteproc,
krzysztof.kozlowski, robh+dt, mathieu.poirier, devicetree,
linux-kernel, konrad.dybcio
On Fri, 23 Dec 2022 14:22:13 +0100, Krzysztof Kozlowski wrote:
> The existing SM8450 DTS (and newer platforms) come with a "gpr" child node,
> not "apr":
>
> sm8450-sony-xperia-nagara-pdx224.dtb: remoteproc@30000000: glink-edge: Unevaluated properties are not allowed ('gpr' was unexpected)
> From schema: Documentation/devicetree/bindings/remoteproc/qcom,sm8350-pas.yaml
>
>
> [...]
Applied, thanks!
[1/1] dt-bindings: remoteproc: qcom,glink-edge: add GPR node
commit: 1135e93682db5f66909f4785b1bfbd798955b2b1
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-12-27 17:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-23 13:22 [PATCH] dt-bindings: remoteproc: qcom,glink-edge: add GPR node Krzysztof Kozlowski
2022-12-26 21:53 ` Rob Herring
2022-12-27 17:42 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®