* [PATCH] RDMA/erdma: Fix refcount leak in erdma_mmap
@ 2022-12-20 12:11 Miaoqian Lin
2022-12-21 2:58 ` Cheng Xu
2022-12-28 9:59 ` Leon Romanovsky
0 siblings, 2 replies; 3+ messages in thread
From: Miaoqian Lin @ 2022-12-20 12:11 UTC (permalink / raw)
To: Cheng Xu, Kai Shen, Jason Gunthorpe, Leon Romanovsky,
Wei Yongjun, Yang Li, linux-rdma, linux-kernel
Cc: linmq006
rdma_user_mmap_entry_get() take reference, we should release it when not
need anymore, add the missing rdma_user_mmap_entry_put() in the error
path to fix it.
Fixes: 155055771704 ("RDMA/erdma: Add verbs implementation")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
drivers/infiniband/hw/erdma/erdma_verbs.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/infiniband/hw/erdma/erdma_verbs.c b/drivers/infiniband/hw/erdma/erdma_verbs.c
index 5dab1e87975b..9c30d78730aa 100644
--- a/drivers/infiniband/hw/erdma/erdma_verbs.c
+++ b/drivers/infiniband/hw/erdma/erdma_verbs.c
@@ -1110,12 +1110,14 @@ int erdma_mmap(struct ib_ucontext *ctx, struct vm_area_struct *vma)
prot = pgprot_device(vma->vm_page_prot);
break;
default:
- return -EINVAL;
+ err = -EINVAL;
+ goto put_entry;
}
err = rdma_user_mmap_io(ctx, vma, PFN_DOWN(entry->address), PAGE_SIZE,
prot, rdma_entry);
+put_entry:
rdma_user_mmap_entry_put(rdma_entry);
return err;
}
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] RDMA/erdma: Fix refcount leak in erdma_mmap
2022-12-20 12:11 [PATCH] RDMA/erdma: Fix refcount leak in erdma_mmap Miaoqian Lin
@ 2022-12-21 2:58 ` Cheng Xu
2022-12-28 9:59 ` Leon Romanovsky
1 sibling, 0 replies; 3+ messages in thread
From: Cheng Xu @ 2022-12-21 2:58 UTC (permalink / raw)
To: Miaoqian Lin, Kai Shen, Jason Gunthorpe, Leon Romanovsky,
Wei Yongjun, Yang Li, linux-rdma, linux-kernel
On 12/20/22 8:11 PM, Miaoqian Lin wrote:
> rdma_user_mmap_entry_get() take reference, we should release it when not
> need anymore, add the missing rdma_user_mmap_entry_put() in the error
> path to fix it.
>
> Fixes: 155055771704 ("RDMA/erdma: Add verbs implementation")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
> ---
> drivers/infiniband/hw/erdma/erdma_verbs.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
Good catch, thanks.
Acked-by: Cheng Xu <chengyou@linux.alibaba.com>
> diff --git a/drivers/infiniband/hw/erdma/erdma_verbs.c b/drivers/infiniband/hw/erdma/erdma_verbs.c
> index 5dab1e87975b..9c30d78730aa 100644
> --- a/drivers/infiniband/hw/erdma/erdma_verbs.c
> +++ b/drivers/infiniband/hw/erdma/erdma_verbs.c
> @@ -1110,12 +1110,14 @@ int erdma_mmap(struct ib_ucontext *ctx, struct vm_area_struct *vma)
> prot = pgprot_device(vma->vm_page_prot);
> break;
> default:
> - return -EINVAL;
> + err = -EINVAL;
> + goto put_entry;
> }
>
> err = rdma_user_mmap_io(ctx, vma, PFN_DOWN(entry->address), PAGE_SIZE,
> prot, rdma_entry);
>
> +put_entry:
> rdma_user_mmap_entry_put(rdma_entry);
> return err;
> }
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] RDMA/erdma: Fix refcount leak in erdma_mmap
2022-12-20 12:11 [PATCH] RDMA/erdma: Fix refcount leak in erdma_mmap Miaoqian Lin
2022-12-21 2:58 ` Cheng Xu
@ 2022-12-28 9:59 ` Leon Romanovsky
1 sibling, 0 replies; 3+ messages in thread
From: Leon Romanovsky @ 2022-12-28 9:59 UTC (permalink / raw)
To: linux-rdma, Kai Shen, Yang Li, linux-kernel, Wei Yongjun,
Cheng Xu, Miaoqian Lin, Jason Gunthorpe
On Tue, 20 Dec 2022 16:11:39 +0400, Miaoqian Lin wrote:
> rdma_user_mmap_entry_get() take reference, we should release it when not
> need anymore, add the missing rdma_user_mmap_entry_put() in the error
> path to fix it.
>
>
Applied, thanks!
[1/1] RDMA/erdma: Fix refcount leak in erdma_mmap
https://git.kernel.org/rdma/rdma/c/ee84146c05ad23
Best regards,
--
Leon Romanovsky <leon@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-12-28 9:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-20 12:11 [PATCH] RDMA/erdma: Fix refcount leak in erdma_mmap Miaoqian Lin
2022-12-21 2:58 ` Cheng Xu
2022-12-28 9:59 ` Leon Romanovsky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®