mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] x86/lib: Fix compiler and kernel-doc warnings
@ 2023-01-03 11:47 Anuradha Weeraman
  2023-01-03 17:02 ` [tip: x86/asm] " tip-bot2 for Anuradha Weeraman
  2023-01-03 17:53 ` tip-bot2 for Anuradha Weeraman
  0 siblings, 2 replies; 3+ messages in thread
From: Anuradha Weeraman @ 2023-01-03 11:47 UTC (permalink / raw)
  To: Thomas Gleixner, Ingo Molnar, Borislav Petkov, Dave Hansen, x86,
	H. Peter Anvin, linux-kernel
  Cc: anuradha

Fix the following W=1 warnings

arch/x86/lib/cmdline.c:
  - Included <asm/cmdline.h> to fix missing-prototypes warnings.
  - Updated comment for __cmdline_find_option_bool to fix a kernel-doc
    warning.

Signed-off-by: Anuradha Weeraman <anuradha@debian.org>
---
 arch/x86/lib/cmdline.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/arch/x86/lib/cmdline.c b/arch/x86/lib/cmdline.c
index b6da09339308..80570eb3c89b 100644
--- a/arch/x86/lib/cmdline.c
+++ b/arch/x86/lib/cmdline.c
@@ -7,16 +7,18 @@
 #include <linux/string.h>
 #include <linux/ctype.h>
 #include <asm/setup.h>
+#include <asm/cmdline.h>
 
 static inline int myisspace(u8 c)
 {
 	return c <= ' ';	/* Close enough approximation */
 }
 
-/**
+/*
  * Find a boolean option (like quiet,noapic,nosmp....)
  *
  * @cmdline: the cmdline string
+ * @max_cmdline_size: the maximum size of cmdline
  * @option: option string to look for
  *
  * Returns the position of that @option (starts counting with 1)
-- 
2.35.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [tip: x86/asm] x86/lib: Fix compiler and kernel-doc warnings
  2023-01-03 11:47 [PATCH] x86/lib: Fix compiler and kernel-doc warnings Anuradha Weeraman
@ 2023-01-03 17:02 ` tip-bot2 for Anuradha Weeraman
  2023-01-03 17:53 ` tip-bot2 for Anuradha Weeraman
  1 sibling, 0 replies; 3+ messages in thread
From: tip-bot2 for Anuradha Weeraman @ 2023-01-03 17:02 UTC (permalink / raw)
  To: linux-tip-commits; +Cc: Anuradha Weeraman, Ingo Molnar, x86, linux-kernel

The following commit has been merged into the x86/asm branch of tip:

Commit-ID:     f843bfeee3d95782677569856ea7f33b87bfd3d0
Gitweb:        https://git.kernel.org/tip/f843bfeee3d95782677569856ea7f33b87bfd3d0
Author:        Anuradha Weeraman <anuradha@debian.org>
AuthorDate:    Tue, 03 Jan 2023 17:17:24 +05:30
Committer:     Ingo Molnar <mingo@kernel.org>
CommitterDate: Tue, 03 Jan 2023 17:56:08 +01:00

x86/lib: Fix compiler and kernel-doc warnings

Fix the following W=1 warnings:

arch/x86/lib/cmdline.c:

  - Include <asm/cmdline.h> to fix missing-prototypes warnings.

  - Update comment for __cmdline_find_option_bool to fix a kernel-doc warning.

Signed-off-by: Anuradha Weeraman <anuradha@debian.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Link: https://lore.kernel.org/r/20230103114725.108431-1-anuradha@debian.org
---
 arch/x86/lib/cmdline.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/arch/x86/lib/cmdline.c b/arch/x86/lib/cmdline.c
index b6da093..80570eb 100644
--- a/arch/x86/lib/cmdline.c
+++ b/arch/x86/lib/cmdline.c
@@ -7,16 +7,18 @@
 #include <linux/string.h>
 #include <linux/ctype.h>
 #include <asm/setup.h>
+#include <asm/cmdline.h>
 
 static inline int myisspace(u8 c)
 {
 	return c <= ' ';	/* Close enough approximation */
 }
 
-/**
+/*
  * Find a boolean option (like quiet,noapic,nosmp....)
  *
  * @cmdline: the cmdline string
+ * @max_cmdline_size: the maximum size of cmdline
  * @option: option string to look for
  *
  * Returns the position of that @option (starts counting with 1)

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [tip: x86/asm] x86/lib: Fix compiler and kernel-doc warnings
  2023-01-03 11:47 [PATCH] x86/lib: Fix compiler and kernel-doc warnings Anuradha Weeraman
  2023-01-03 17:02 ` [tip: x86/asm] " tip-bot2 for Anuradha Weeraman
@ 2023-01-03 17:53 ` tip-bot2 for Anuradha Weeraman
  1 sibling, 0 replies; 3+ messages in thread
From: tip-bot2 for Anuradha Weeraman @ 2023-01-03 17:53 UTC (permalink / raw)
  To: linux-tip-commits; +Cc: Anuradha Weeraman, Ingo Molnar, x86, linux-kernel

The following commit has been merged into the x86/asm branch of tip:

Commit-ID:     65c24d7b0f9142c6acc9bd6dabeba22767077681
Gitweb:        https://git.kernel.org/tip/65c24d7b0f9142c6acc9bd6dabeba22767077681
Author:        Anuradha Weeraman <anuradha@debian.org>
AuthorDate:    Tue, 03 Jan 2023 17:17:24 +05:30
Committer:     Ingo Molnar <mingo@kernel.org>
CommitterDate: Tue, 03 Jan 2023 18:46:21 +01:00

x86/lib: Fix compiler and kernel-doc warnings

Fix the following W=1 warnings:

arch/x86/lib/cmdline.c:

  - Include <asm/cmdline.h> to fix missing-prototypes warnings.

  - Update comment for __cmdline_find_option_bool to fix a kernel-doc warning.

Signed-off-by: Anuradha Weeraman <anuradha@debian.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Link: https://lore.kernel.org/r/20230103114725.108431-1-anuradha@debian.org
---
 arch/x86/lib/cmdline.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/arch/x86/lib/cmdline.c b/arch/x86/lib/cmdline.c
index b6da093..80570eb 100644
--- a/arch/x86/lib/cmdline.c
+++ b/arch/x86/lib/cmdline.c
@@ -7,16 +7,18 @@
 #include <linux/string.h>
 #include <linux/ctype.h>
 #include <asm/setup.h>
+#include <asm/cmdline.h>
 
 static inline int myisspace(u8 c)
 {
 	return c <= ' ';	/* Close enough approximation */
 }
 
-/**
+/*
  * Find a boolean option (like quiet,noapic,nosmp....)
  *
  * @cmdline: the cmdline string
+ * @max_cmdline_size: the maximum size of cmdline
  * @option: option string to look for
  *
  * Returns the position of that @option (starts counting with 1)

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-01-03 17:53 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-03 11:47 [PATCH] x86/lib: Fix compiler and kernel-doc warnings Anuradha Weeraman
2023-01-03 17:02 ` [tip: x86/asm] " tip-bot2 for Anuradha Weeraman
2023-01-03 17:53 ` tip-bot2 for Anuradha Weeraman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®