* [PATCH] x86/rapl: Treat Tigerlake like Icelake
@ 2022-12-28 11:34 Rodrigo Vivi
2023-01-03 18:00 ` [tip: perf/urgent] perf/x86/rapl: " tip-bot2 for Chris Wilson
0 siblings, 1 reply; 2+ messages in thread
From: Rodrigo Vivi @ 2022-12-28 11:34 UTC (permalink / raw)
To: x86, linux-perf-users, linux-kernel
Cc: Zhang Rui, Peter Zijlstra, Chris Wilson, Rodrigo Vivi
From: Chris Wilson <chris@chris-wilson.co.uk>
Since Tigerlake seems to have inherited its cstates and other rapl power
caps from Icelake, assume it also follows Icelake for its rapl events.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
Based on the recent additions it looks like Tigerlake was a missed
case in these events/rapl.c and that this old patch from Chris is the
right way to go.
I found this patch on our drm-intel's topic/core-for-CI branch while
rebasing it towards v6.2-rc1.
arch/x86/events/rapl.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/x86/events/rapl.c b/arch/x86/events/rapl.c
index a829492bca4c..ae5779ea4417 100644
--- a/arch/x86/events/rapl.c
+++ b/arch/x86/events/rapl.c
@@ -800,6 +800,8 @@ static const struct x86_cpu_id rapl_model_match[] __initconst = {
X86_MATCH_INTEL_FAM6_MODEL(ICELAKE_X, &model_hsx),
X86_MATCH_INTEL_FAM6_MODEL(COMETLAKE_L, &model_skl),
X86_MATCH_INTEL_FAM6_MODEL(COMETLAKE, &model_skl),
+ X86_MATCH_INTEL_FAM6_MODEL(TIGERLAKE_L, &model_skl),
+ X86_MATCH_INTEL_FAM6_MODEL(TIGERLAKE, &model_skl),
X86_MATCH_INTEL_FAM6_MODEL(ALDERLAKE, &model_skl),
X86_MATCH_INTEL_FAM6_MODEL(ALDERLAKE_L, &model_skl),
X86_MATCH_INTEL_FAM6_MODEL(ALDERLAKE_N, &model_skl),
--
2.38.1
^ permalink raw reply [flat|nested] 2+ messages in thread* [tip: perf/urgent] perf/x86/rapl: Treat Tigerlake like Icelake
2022-12-28 11:34 [PATCH] x86/rapl: Treat Tigerlake like Icelake Rodrigo Vivi
@ 2023-01-03 18:00 ` tip-bot2 for Chris Wilson
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot2 for Chris Wilson @ 2023-01-03 18:00 UTC (permalink / raw)
To: linux-tip-commits
Cc: Chris Wilson, Rodrigo Vivi, Ingo Molnar, Peter Zijlstra,
Stephane Eranian, Zhang Rui, x86, linux-kernel
The following commit has been merged into the perf/urgent branch of tip:
Commit-ID: c07311b5509f6035f1dd828db3e90ff4859cf3b9
Gitweb: https://git.kernel.org/tip/c07311b5509f6035f1dd828db3e90ff4859cf3b9
Author: Chris Wilson <chris@chris-wilson.co.uk>
AuthorDate: Wed, 28 Dec 2022 06:34:54 -05:00
Committer: Ingo Molnar <mingo@kernel.org>
CommitterDate: Tue, 03 Jan 2023 18:55:35 +01:00
perf/x86/rapl: Treat Tigerlake like Icelake
Since Tigerlake seems to have inherited its cstates and other RAPL power
caps from Icelake, assume it also follows Icelake for its RAPL events.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Cc: Zhang Rui <rui.zhang@intel.com>
Link: https://lore.kernel.org/r/20221228113454.1199118-1-rodrigo.vivi@intel.com
---
arch/x86/events/rapl.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/x86/events/rapl.c b/arch/x86/events/rapl.c
index a829492..ae5779e 100644
--- a/arch/x86/events/rapl.c
+++ b/arch/x86/events/rapl.c
@@ -800,6 +800,8 @@ static const struct x86_cpu_id rapl_model_match[] __initconst = {
X86_MATCH_INTEL_FAM6_MODEL(ICELAKE_X, &model_hsx),
X86_MATCH_INTEL_FAM6_MODEL(COMETLAKE_L, &model_skl),
X86_MATCH_INTEL_FAM6_MODEL(COMETLAKE, &model_skl),
+ X86_MATCH_INTEL_FAM6_MODEL(TIGERLAKE_L, &model_skl),
+ X86_MATCH_INTEL_FAM6_MODEL(TIGERLAKE, &model_skl),
X86_MATCH_INTEL_FAM6_MODEL(ALDERLAKE, &model_skl),
X86_MATCH_INTEL_FAM6_MODEL(ALDERLAKE_L, &model_skl),
X86_MATCH_INTEL_FAM6_MODEL(ALDERLAKE_N, &model_skl),
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-01-03 18:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-28 11:34 [PATCH] x86/rapl: Treat Tigerlake like Icelake Rodrigo Vivi
2023-01-03 18:00 ` [tip: perf/urgent] perf/x86/rapl: " tip-bot2 for Chris Wilson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®