mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v1] ASoC: nau8315: remove dependency on GPIOLIB
@ 2023-01-08 11:43 Ajye Huang
  2023-01-09 16:49 ` Mark Brown
  0 siblings, 1 reply; 2+ messages in thread
From: Ajye Huang @ 2023-01-08 11:43 UTC (permalink / raw)
  To: linux-kernel
  Cc: Mark Brown, Pierre-Louis Bossart, Sean Paul, Terry Cheong,
	Liam Girdwood, Sasha Levin, Lucas Tanure, Cezary Rojewski,
	Ryan Lee, Charles Keepax, Jaroslav Kysela, David Lin, Brent Lu,
	Takashi Iwai, Linux Patches Robot, amadeuszx.slawinski,
	alsa-devel, Ajye Huang, kernel test robot

commit dcc2c012c7691 ("ASoC: Fix gpiolib dependencies") removed a
series of unnecessary dependencies on GPIOLIB when the gpio was
optional.

A similar simplification seems valid for nau8315, so remove the
dependency as well. This will avoid the following warning

  WARNING: unmet direct dependencies detected for SND_SOC_NAU8315

   Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] &&
                   GPIOLIB [=n]
   Selected by [y]:

     - SND_SOC_INTEL_SOF_NAU8825_MACH [=y] && SOUND [=y] && !UML &&
       SND [=y] && SND_SOC [=y] && SND_SOC_INTEL_MACH [=y] &&
       (SND_SOC_SOF_HDA_LINK [=y] || SND_SOC_SOF_BAYTRAIL [=n]) &&
       I2C [=y] && ACPI [=y] && SND_HDA_CODEC_HDMI [=y] &&
       SND_SOC_SOF_HDA_AUDIO_CODEC [=y] && (MFD_INTEL_LPSS [=n] ||
       COMPILE_TEST [=y])

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Ajye Huang <ajye_huang@compal.corp-partner.google.com>
---
 sound/soc/codecs/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
index bbd401e52be1..e165addec25f 100644
--- a/sound/soc/codecs/Kconfig
+++ b/sound/soc/codecs/Kconfig
@@ -1863,7 +1863,6 @@ config SND_SOC_MT6660
 
 config SND_SOC_NAU8315
 	tristate "Nuvoton Technology Corporation NAU8315 CODEC"
-	depends on GPIOLIB
 
 config SND_SOC_NAU8540
 	tristate "Nuvoton Technology Corporation NAU85L40 CODEC"
-- 
2.25.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH v1] ASoC: nau8315: remove dependency on GPIOLIB
  2023-01-08 11:43 [PATCH v1] ASoC: nau8315: remove dependency on GPIOLIB Ajye Huang
@ 2023-01-09 16:49 ` Mark Brown
  0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2023-01-09 16:49 UTC (permalink / raw)
  To: linux-kernel, Ajye Huang
  Cc: Pierre-Louis Bossart, Sean Paul, Terry Cheong, Liam Girdwood,
	Sasha Levin, Lucas Tanure, Cezary Rojewski, Ryan Lee,
	Charles Keepax, Jaroslav Kysela, David Lin, Brent Lu,
	Takashi Iwai, Linux Patches Robot, amadeuszx.slawinski,
	alsa-devel, kernel test robot

On Sun, 08 Jan 2023 19:43:51 +0800, Ajye Huang wrote:
> commit dcc2c012c7691 ("ASoC: Fix gpiolib dependencies") removed a
> series of unnecessary dependencies on GPIOLIB when the gpio was
> optional.
> 
> A similar simplification seems valid for nau8315, so remove the
> dependency as well. This will avoid the following warning
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: nau8315: remove dependency on GPIOLIB
      commit: 523ba3b70fc572f69673d8bd88af00df0e716529

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-01-09 16:50 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-08 11:43 [PATCH v1] ASoC: nau8315: remove dependency on GPIOLIB Ajye Huang
2023-01-09 16:49 ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®