mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v2 1/3] arm64: dts: qcom: sm8250: drop unused clock-frequency from rx-macro
@ 2023-01-18  9:42 Krzysztof Kozlowski
  2023-01-18  9:42 ` [PATCH v2 2/3] arm64: dts: qcom: sc8280xp: drop bogus clock-controller property Krzysztof Kozlowski
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2023-01-18  9:42 UTC (permalink / raw)
  To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, linux-arm-msm, devicetree, linux-kernel
  Cc: Krzysztof Kozlowski

Neither qcom,sm8250-lpass-rx-macro bindings nor the driver use
"clock-frequency" property.

  sm8250-mtp.dtb: rxmacro@3200000: Unevaluated properties are not allowed ('clock-frequency' was unexpected)

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

---

Changes since v1:
1. Add Rb tag.
2. Split from SDM845 audio patchset, so this can easily be picked up.
---
 arch/arm64/boot/dts/qcom/sm8250.dtsi | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi
index f614992709d2..b22569101314 100644
--- a/arch/arm64/boot/dts/qcom/sm8250.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi
@@ -2301,7 +2301,6 @@ rxmacro: rxmacro@3200000 {
 			clock-names = "mclk", "npl", "macro", "dcodec", "fsgen";
 
 			#clock-cells = <0>;
-			clock-frequency = <9600000>;
 			clock-output-names = "mclk";
 			#sound-dai-cells = <1>;
 		};
-- 
2.34.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH v2 2/3] arm64: dts: qcom: sc8280xp: drop bogus clock-controller property
  2023-01-18  9:42 [PATCH v2 1/3] arm64: dts: qcom: sm8250: drop unused clock-frequency from rx-macro Krzysztof Kozlowski
@ 2023-01-18  9:42 ` Krzysztof Kozlowski
  2023-01-18  9:42 ` [PATCH v2 3/3] arm64: dts: qcom: sc8280xp: drop unused properties from tx-macro Krzysztof Kozlowski
  2023-01-18 22:50 ` (subset) [PATCH v2 1/3] arm64: dts: qcom: sm8250: drop unused clock-frequency from rx-macro Bjorn Andersson
  2 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2023-01-18  9:42 UTC (permalink / raw)
  To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, linux-arm-msm, devicetree, linux-kernel
  Cc: Krzysztof Kozlowski

There is no "clock-controller" property:

  sa8295p-adp.dtb: service@2: clock-controller: 'clock-controller' does not match any of the regexes: 'pinctrl-[0-9]+'
    From schema: Documentation/devicetree/bindings/sound/qcom,q6prm.yaml

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

---

Changes since v1:
1. Split from SDM845 audio patchset, so this can easily be picked up.
---
 arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
index 547454866c1b..fb1aa08c2524 100644
--- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
@@ -1716,7 +1716,6 @@ q6prm: service@2 {
 									 "msm/adsp/audio_pd";
 						q6prmcc: clock-controller {
 							compatible = "qcom,q6prm-lpass-clocks";
-							clock-controller;
 							#clock-cells = <2>;
 						};
 					};
-- 
2.34.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH v2 3/3] arm64: dts: qcom: sc8280xp: drop unused properties from tx-macro
  2023-01-18  9:42 [PATCH v2 1/3] arm64: dts: qcom: sm8250: drop unused clock-frequency from rx-macro Krzysztof Kozlowski
  2023-01-18  9:42 ` [PATCH v2 2/3] arm64: dts: qcom: sc8280xp: drop bogus clock-controller property Krzysztof Kozlowski
@ 2023-01-18  9:42 ` Krzysztof Kozlowski
  2023-01-18 22:50 ` (subset) [PATCH v2 1/3] arm64: dts: qcom: sm8250: drop unused clock-frequency from rx-macro Bjorn Andersson
  2 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2023-01-18  9:42 UTC (permalink / raw)
  To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, linux-arm-msm, devicetree, linux-kernel
  Cc: Krzysztof Kozlowski

tx-macro does not have children and does not allow address/size cells:

  sc8280xp-crd.dtb: txmacro@3220000: Unevaluated properties are not allowed ('#address-cells', '#size-cells' were unexpected)

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

---

Changes since v1:
1. Add Rb tag.
2. Split from SDM845 audio patchset, so this can easily be picked up.
---
 arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
index fb1aa08c2524..bc698e417fae 100644
--- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
@@ -1789,8 +1789,6 @@ txmacro: txmacro@3220000 {
 			clock-output-names = "mclk";
 
 			#clock-cells = <0>;
-			#address-cells = <2>;
-			#size-cells = <2>;
 			#sound-dai-cells = <1>;
 		};
 
-- 
2.34.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: (subset) [PATCH v2 1/3] arm64: dts: qcom: sm8250: drop unused clock-frequency from rx-macro
  2023-01-18  9:42 [PATCH v2 1/3] arm64: dts: qcom: sm8250: drop unused clock-frequency from rx-macro Krzysztof Kozlowski
  2023-01-18  9:42 ` [PATCH v2 2/3] arm64: dts: qcom: sc8280xp: drop bogus clock-controller property Krzysztof Kozlowski
  2023-01-18  9:42 ` [PATCH v2 3/3] arm64: dts: qcom: sc8280xp: drop unused properties from tx-macro Krzysztof Kozlowski
@ 2023-01-18 22:50 ` Bjorn Andersson
  2 siblings, 0 replies; 4+ messages in thread
From: Bjorn Andersson @ 2023-01-18 22:50 UTC (permalink / raw)
  To: konrad.dybcio, robh+dt, devicetree, krzysztof.kozlowski,
	linux-arm-msm, krzysztof.kozlowski+dt, linux-kernel, agross

On Wed, 18 Jan 2023 10:42:22 +0100, Krzysztof Kozlowski wrote:
> Neither qcom,sm8250-lpass-rx-macro bindings nor the driver use
> "clock-frequency" property.
> 
>   sm8250-mtp.dtb: rxmacro@3200000: Unevaluated properties are not allowed ('clock-frequency' was unexpected)
> 
> 

Applied, thanks!

[1/3] arm64: dts: qcom: sm8250: drop unused clock-frequency from rx-macro
      commit: 30186f8573af259ff9928512c3256bf7f66e48e6
[2/3] arm64: dts: qcom: sc8280xp: drop bogus clock-controller property
      commit: c75286fe8968cb0cc4f0cc83caa2b2b38f6f6d4f
[3/3] arm64: dts: qcom: sc8280xp: drop unused properties from tx-macro
      commit: 91238d52fb0730564eec520541ec7bc4e120ae52

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-01-18 22:50 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-18  9:42 [PATCH v2 1/3] arm64: dts: qcom: sm8250: drop unused clock-frequency from rx-macro Krzysztof Kozlowski
2023-01-18  9:42 ` [PATCH v2 2/3] arm64: dts: qcom: sc8280xp: drop bogus clock-controller property Krzysztof Kozlowski
2023-01-18  9:42 ` [PATCH v2 3/3] arm64: dts: qcom: sc8280xp: drop unused properties from tx-macro Krzysztof Kozlowski
2023-01-18 22:50 ` (subset) [PATCH v2 1/3] arm64: dts: qcom: sm8250: drop unused clock-frequency from rx-macro Bjorn Andersson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®