* [PATCH 2/3] ARM: dts: exynos: move MIPI phy to PMU node in Exynos3250
2023-02-07 19:28 [PATCH 1/3] dt-bindings: soc: samsung: exynos-pmu: allow phys as child on Exynos3 and Exynos4 Krzysztof Kozlowski
@ 2023-02-07 19:28 ` Krzysztof Kozlowski
2023-02-07 19:28 ` [PATCH 3/3] ARM: dts: exynos: move MIPI phy to PMU node in Exynos4 Krzysztof Kozlowski
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2023-02-07 19:28 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Alim Akhtar, devicetree,
linux-arm-kernel, linux-samsung-soc, linux-kernel
Cc: Krzysztof Kozlowski
The MIPI phy is actually part of the Power Management Unit system
controller. It does not have its own address space, thus keeping the
node under soc causes warnings:
exynos3250-artik5-eval.dtb: soc: video-phy: {'compatible': ['samsung,s5pv210-mipi-video-phy'],
'#phy-cells': [[1]], 'syscon': [[15]], 'phandle': [[23]]} should not be valid under {'type': 'object'}
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm/boot/dts/exynos3250.dtsi | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi
index 28bb2ce8ccf7..cb2c59c98c4a 100644
--- a/arch/arm/boot/dts/exynos3250.dtsi
+++ b/arch/arm/boot/dts/exynos3250.dtsi
@@ -346,7 +346,7 @@ sys_reg: syscon@10010000 {
};
pmu_system_controller: system-controller@10020000 {
- compatible = "samsung,exynos3250-pmu", "syscon";
+ compatible = "samsung,exynos3250-pmu", "simple-mfd", "syscon";
reg = <0x10020000 0x4000>;
interrupt-controller;
#interrupt-cells = <3>;
@@ -354,12 +354,11 @@ pmu_system_controller: system-controller@10020000 {
clock-names = "clkout8";
clocks = <&cmu CLK_FIN_PLL>;
#clock-cells = <1>;
- };
- mipi_phy: video-phy {
- compatible = "samsung,s5pv210-mipi-video-phy";
- #phy-cells = <1>;
- syscon = <&pmu_system_controller>;
+ mipi_phy: mipi-phy {
+ compatible = "samsung,s5pv210-mipi-video-phy";
+ #phy-cells = <1>;
+ };
};
pd_cam: power-domain@10023c00 {
--
2.34.1
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH 3/3] ARM: dts: exynos: move MIPI phy to PMU node in Exynos4
2023-02-07 19:28 [PATCH 1/3] dt-bindings: soc: samsung: exynos-pmu: allow phys as child on Exynos3 and Exynos4 Krzysztof Kozlowski
2023-02-07 19:28 ` [PATCH 2/3] ARM: dts: exynos: move MIPI phy to PMU node in Exynos3250 Krzysztof Kozlowski
@ 2023-02-07 19:28 ` Krzysztof Kozlowski
2023-02-08 23:48 ` [PATCH 1/3] dt-bindings: soc: samsung: exynos-pmu: allow phys as child on Exynos3 and Exynos4 Rob Herring
2023-03-06 11:39 ` Krzysztof Kozlowski
3 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2023-02-07 19:28 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Alim Akhtar, devicetree,
linux-arm-kernel, linux-samsung-soc, linux-kernel
Cc: Krzysztof Kozlowski
The MIPI phy is actually part of the Power Management Unit system
controller. It does not have its own address space, thus keeping the
node under soc causes warnings:
xynos4412-i9305.dtb: soc: video-phy: {'compatible': ['samsung,s5pv210-mipi-video-phy'],
'#phy-cells': [[1]], 'syscon': [[11]], 'phandle': [[13]]} should not be valid under {'type': 'object'}
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm/boot/dts/exynos4.dtsi | 13 ++++++-------
arch/arm/boot/dts/exynos4412.dtsi | 2 +-
2 files changed, 7 insertions(+), 8 deletions(-)
diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
index 44dcb1377475..8dd6976ab0a7 100644
--- a/arch/arm/boot/dts/exynos4.dtsi
+++ b/arch/arm/boot/dts/exynos4.dtsi
@@ -105,12 +105,6 @@ memory-controller@12570000 {
reg = <0x12570000 0x14>;
};
- mipi_phy: video-phy {
- compatible = "samsung,s5pv210-mipi-video-phy";
- #phy-cells = <1>;
- syscon = <&pmu_system_controller>;
- };
-
pd_mfc: power-domain@10023c40 {
compatible = "samsung,exynos4210-pd";
reg = <0x10023c40 0x20>;
@@ -181,11 +175,16 @@ sys_reg: syscon@10010000 {
};
pmu_system_controller: system-controller@10020000 {
- compatible = "samsung,exynos4210-pmu", "syscon";
+ compatible = "samsung,exynos4210-pmu", "simple-mfd", "syscon";
reg = <0x10020000 0x4000>;
interrupt-controller;
#interrupt-cells = <3>;
interrupt-parent = <&gic>;
+
+ mipi_phy: mipi-phy {
+ compatible = "samsung,s5pv210-mipi-video-phy";
+ #phy-cells = <1>;
+ };
};
dsi_0: dsi@11c80000 {
diff --git a/arch/arm/boot/dts/exynos4412.dtsi b/arch/arm/boot/dts/exynos4412.dtsi
index 11f9dd94b6b3..7fa3e5fd6801 100644
--- a/arch/arm/boot/dts/exynos4412.dtsi
+++ b/arch/arm/boot/dts/exynos4412.dtsi
@@ -798,7 +798,7 @@ &pmu {
};
&pmu_system_controller {
- compatible = "samsung,exynos4412-pmu", "syscon";
+ compatible = "samsung,exynos4412-pmu", "simple-mfd", "syscon";
clock-names = "clkout0", "clkout1", "clkout2", "clkout3",
"clkout4", "clkout8", "clkout9";
clocks = <&clock CLK_OUT_DMC>, <&clock CLK_OUT_TOP>,
--
2.34.1
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 1/3] dt-bindings: soc: samsung: exynos-pmu: allow phys as child on Exynos3 and Exynos4
2023-02-07 19:28 [PATCH 1/3] dt-bindings: soc: samsung: exynos-pmu: allow phys as child on Exynos3 and Exynos4 Krzysztof Kozlowski
2023-02-07 19:28 ` [PATCH 2/3] ARM: dts: exynos: move MIPI phy to PMU node in Exynos3250 Krzysztof Kozlowski
2023-02-07 19:28 ` [PATCH 3/3] ARM: dts: exynos: move MIPI phy to PMU node in Exynos4 Krzysztof Kozlowski
@ 2023-02-08 23:48 ` Rob Herring
2023-03-06 11:39 ` Krzysztof Kozlowski
3 siblings, 0 replies; 5+ messages in thread
From: Rob Herring @ 2023-02-08 23:48 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Alim Akhtar, devicetree, Krzysztof Kozlowski, linux-samsung-soc,
linux-arm-kernel, Rob Herring, linux-kernel
On Tue, 07 Feb 2023 20:28:49 +0100, Krzysztof Kozlowski wrote:
> Just like on Exynos5250, Exynos5420 and Exynos5433 the MIPI phy is
> actually part of the Power Management Unit system controller thus allow
> it as PMU's child.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> .../bindings/soc/samsung/exynos-pmu.yaml | 23 +++++++++++++++++--
> 1 file changed, 21 insertions(+), 2 deletions(-)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/3] dt-bindings: soc: samsung: exynos-pmu: allow phys as child on Exynos3 and Exynos4
2023-02-07 19:28 [PATCH 1/3] dt-bindings: soc: samsung: exynos-pmu: allow phys as child on Exynos3 and Exynos4 Krzysztof Kozlowski
` (2 preceding siblings ...)
2023-02-08 23:48 ` [PATCH 1/3] dt-bindings: soc: samsung: exynos-pmu: allow phys as child on Exynos3 and Exynos4 Rob Herring
@ 2023-03-06 11:39 ` Krzysztof Kozlowski
3 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2023-03-06 11:39 UTC (permalink / raw)
To: linux-samsung-soc, devicetree, Krzysztof Kozlowski, linux-kernel,
Rob Herring, Krzysztof Kozlowski, Alim Akhtar, linux-arm-kernel
On Tue, 7 Feb 2023 20:28:49 +0100, Krzysztof Kozlowski wrote:
> Just like on Exynos5250, Exynos5420 and Exynos5433 the MIPI phy is
> actually part of the Power Management Unit system controller thus allow
> it as PMU's child.
>
>
Applied, thanks!
[1/3] dt-bindings: soc: samsung: exynos-pmu: allow phys as child on Exynos3 and Exynos4
https://git.kernel.org/krzk/linux/c/e3fc841ef02fe065255327b4c0259ac94bc9763c
[2/3] ARM: dts: exynos: move MIPI phy to PMU node in Exynos3250
https://git.kernel.org/krzk/linux/c/37688852fd6f4fed2b3800a7652be87147137125
[3/3] ARM: dts: exynos: move MIPI phy to PMU node in Exynos4
https://git.kernel.org/krzk/linux/c/d237b2270c68032ad3471ca82d1f3581398179c6
Best regards,
--
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
^ permalink raw reply [flat|nested] 5+ messages in thread