mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] net: dsa: ocelot: fix selecting MFD_OCELOT
@ 2023-02-15 10:46 Lukas Bulwahn
  2023-02-15 16:29 ` Colin Foster
  2023-02-16 12:20 ` patchwork-bot+netdevbpf
  0 siblings, 2 replies; 3+ messages in thread
From: Lukas Bulwahn @ 2023-02-15 10:46 UTC (permalink / raw)
  To: Colin Foster, Vladimir Oltean, Florian Fainelli, Jakub Kicinski
  Cc: Claudiu Manoil, Alexandre Belloni, UNGLinuxDriver, Andrew Lunn,
	David S . Miller, Eric Dumazet, Paolo Abeni, netdev,
	kernel-janitors, linux-kernel, Lukas Bulwahn

Commit 3d7316ac81ac ("net: dsa: ocelot: add external ocelot switch
control") adds config NET_DSA_MSCC_OCELOT_EXT, which selects the
non-existing config MFD_OCELOT_CORE.

Replace this select with the intended and existing MFD_OCELOT.

Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
 drivers/net/dsa/ocelot/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/dsa/ocelot/Kconfig b/drivers/net/dsa/ocelot/Kconfig
index eff0a7dfcd21..081e7a88ea02 100644
--- a/drivers/net/dsa/ocelot/Kconfig
+++ b/drivers/net/dsa/ocelot/Kconfig
@@ -14,7 +14,7 @@ config NET_DSA_MSCC_OCELOT_EXT
 	depends on NET_VENDOR_MICROSEMI
 	depends on PTP_1588_CLOCK_OPTIONAL
 	select MDIO_MSCC_MIIM
-	select MFD_OCELOT_CORE
+	select MFD_OCELOT
 	select MSCC_OCELOT_SWITCH_LIB
 	select NET_DSA_MSCC_FELIX_DSA_LIB
 	select NET_DSA_TAG_OCELOT_8021Q
-- 
2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [PATCH] net: dsa: ocelot: fix selecting MFD_OCELOT
  2023-02-15 10:46 [PATCH] net: dsa: ocelot: fix selecting MFD_OCELOT Lukas Bulwahn
@ 2023-02-15 16:29 ` Colin Foster
  2023-02-16 12:20 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: Colin Foster @ 2023-02-15 16:29 UTC (permalink / raw)
  To: Lukas Bulwahn
  Cc: Vladimir Oltean, Florian Fainelli, Jakub Kicinski,
	Claudiu Manoil, Alexandre Belloni, UNGLinuxDriver, Andrew Lunn,
	David S . Miller, Eric Dumazet, Paolo Abeni, netdev,
	kernel-janitors, linux-kernel

Hi Lukas,

On Wed, Feb 15, 2023 at 11:46:31AM +0100, Lukas Bulwahn wrote:
> Commit 3d7316ac81ac ("net: dsa: ocelot: add external ocelot switch
> control") adds config NET_DSA_MSCC_OCELOT_EXT, which selects the
> non-existing config MFD_OCELOT_CORE.
> 
> Replace this select with the intended and existing MFD_OCELOT.

Thanks for this. We pivoted away from *_CORE a while back and I clearly
missed this. It can go through net-next this week.

Acked-by: Colin Foster <colin.foster@in-advantage.com>

> 
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> ---
>  drivers/net/dsa/ocelot/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/dsa/ocelot/Kconfig b/drivers/net/dsa/ocelot/Kconfig
> index eff0a7dfcd21..081e7a88ea02 100644
> --- a/drivers/net/dsa/ocelot/Kconfig
> +++ b/drivers/net/dsa/ocelot/Kconfig
> @@ -14,7 +14,7 @@ config NET_DSA_MSCC_OCELOT_EXT
>  	depends on NET_VENDOR_MICROSEMI
>  	depends on PTP_1588_CLOCK_OPTIONAL
>  	select MDIO_MSCC_MIIM
> -	select MFD_OCELOT_CORE
> +	select MFD_OCELOT
>  	select MSCC_OCELOT_SWITCH_LIB
>  	select NET_DSA_MSCC_FELIX_DSA_LIB
>  	select NET_DSA_TAG_OCELOT_8021Q
> -- 
> 2.17.1
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [PATCH] net: dsa: ocelot: fix selecting MFD_OCELOT
  2023-02-15 10:46 [PATCH] net: dsa: ocelot: fix selecting MFD_OCELOT Lukas Bulwahn
  2023-02-15 16:29 ` Colin Foster
@ 2023-02-16 12:20 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-02-16 12:20 UTC (permalink / raw)
  To: Lukas Bulwahn
  Cc: colin.foster, vladimir.oltean, f.fainelli, kuba, claudiu.manoil,
	alexandre.belloni, UNGLinuxDriver, andrew, davem, edumazet,
	pabeni, netdev, kernel-janitors, linux-kernel

Hello:

This patch was applied to netdev/net-next.git (master)
by Paolo Abeni <pabeni@redhat.com>:

On Wed, 15 Feb 2023 11:46:31 +0100 you wrote:
> Commit 3d7316ac81ac ("net: dsa: ocelot: add external ocelot switch
> control") adds config NET_DSA_MSCC_OCELOT_EXT, which selects the
> non-existing config MFD_OCELOT_CORE.
> 
> Replace this select with the intended and existing MFD_OCELOT.
> 
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> 
> [...]

Here is the summary with links:
  - net: dsa: ocelot: fix selecting MFD_OCELOT
    https://git.kernel.org/netdev/net-next/c/f5b12be34249

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-02-16 12:20 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-15 10:46 [PATCH] net: dsa: ocelot: fix selecting MFD_OCELOT Lukas Bulwahn
2023-02-15 16:29 ` Colin Foster
2023-02-16 12:20 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®