mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jeff Moyer <jmoyer@redhat.com>
To: mpm@selenic.com
Cc: linux-kernel@vger.kernel.org
Subject: netpoll_setup questions
Date: Wed, 27 Oct 2004 11:50:05 -0400	[thread overview]
Message-ID: <16767.50093.59665.83462@segfault.boston.redhat.com> (raw)

Hi, Matt,

The section of code in the body of this if statement:

	if (!(ndev->flags & IFF_UP)) {

is a bit broken.  First, upon discussion with jgarzik, it seems we should
not check for IFF_UP, but instead do netif_running.  However, I'm wondering
why we try to force the interface up in the first place?  Just because we
force it up doesn't mean that it will get an IP address.  And, in the case
where it doesn't, you will get an oops further on when dereferencing the
ifa_list.  So, why does this section of code exist at all?  If it has a
good purpose, can we replace it with a call to ndev->open?

Thanks!

Jeff

             reply	other threads:[~2004-10-27 15:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-27 15:50 Jeff Moyer [this message]
2004-10-27 17:30 ` Matt Mackall
2004-10-27 18:58   ` Jeff Moyer
2004-10-27 19:41     ` Matt Mackall
2004-10-27 19:44       ` Jeff Moyer
2004-10-27 20:29         ` Matt Mackall
2004-10-28 15:58           ` Jeff Moyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=16767.50093.59665.83462@segfault.boston.redhat.com \
    --to=jmoyer@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mpm@selenic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®