Re: netpoll_setup questions

[Jeff Moyer <jmoyer@redhat.com>]

==> Regarding Re: netpoll_setup questions; Matt Mackall <mpm@selenic.com> adds:

mpm> On Wed, Oct 27, 2004 at 03:44:33PM -0400, Jeff Moyer wrote: Again,
mpm> does the oops actually happen? I'd expect I'd have seen it by now if
mpm> this were really a problem, but I don't mind adding another check.
>> I'm sorry, I should have said this before.  Yes, it occurs.  You simply
>> need to have an interface in the down state, plugged into a network that
>> will not auto-assign an address.  Then, modprobe netconsole, and don't
>> specify what the local IP address is.  Believe it or not, I have a bug
>> filed on this.  ;)

mpm> Ok, fair enough. Resend your patch when you've tested it and I'll
mpm> forward it on to Andrew.

Patch attached, unchanged.  This did indeed fix the problem.

-Jeff

Signed-off by: Jeff Moyer <jmoyer@redhat.com>

--- linux-2.6.9/net/core/netpoll.c~	2004-10-21 17:49:10.000000000 -0400
+++ linux-2.6.9/net/core/netpoll.c	2004-10-27 14:53:57.492149880 -0400
@@ -571,7 +571,7 @@ int netpoll_setup(struct netpoll *np)
 		goto release;
 	}
 
-	if (!(ndev->flags & IFF_UP)) {
+	if (!netif_running(ndev)) {
 		unsigned short oflags;
 		unsigned long atmost, atleast;
 
@@ -617,7 +617,7 @@ int netpoll_setup(struct netpoll *np)
 		rcu_read_lock();
 		in_dev = __in_dev_get(ndev);
 
-		if (!in_dev) {
+		if (!in_dev || !in_dev->ifa_list) {
 			rcu_read_unlock();
 			printk(KERN_ERR "%s: no IP address for %s, aborting\n",
 			       np->name, np->dev_name);