From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Jiang Liu <jiang.liu@linux.intel.com>
Cc: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
"H. Peter Anvin" <hpa@linux.intel.com>,
Len Brown <len.brown@intel.com>, Len Brown <lenb@kernel.org>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] intel_idle: close avn_cstates array with correct marker
Date: Fri, 10 Jan 2014 14:32:36 +0100 [thread overview]
Message-ID: <1676949.y75c76bCzK@vostro.rjw.lan> (raw)
In-Reply-To: <52CF5402.70106@linux.intel.com>
On Friday, January 10, 2014 09:59:30 AM Jiang Liu wrote:
>
> On 2014/1/9 21:31, Rafael J. Wysocki wrote:
> > On Thursday, January 09, 2014 03:30:27 PM Jiang Liu wrote:
> >> Close avn_cstates array with correct marker to avoid overflow
> >> in function intel_idle_cpu_init().
> >>
> >> Signed-off-by: Jiang Liu <jiang.liu@linux.intel.com>
> >> Cc: <stable@vger.kernel.org> # 3.13
> >
> > Why did you mark it for 3.13-stable? 3.13 hasn't been released yet, so this
> > can be pushed for 3.13 still.
> >
> > Is the problem present in 3.13-rc? If so, has it been introduced by any
> > recent commits or was it there before? In which case, do we need this patch
> > in stable as well?
> >
> > Rafael
> Hi Rafael,
> This issue is introduced in 3.13-rc2, and I feel it's too late
> to catch up with 3.13 window, so mark it for 3.13 speculatively.
> After more thoughts, I feel this patch should be divided into
> two patches.
> One is to temporarily remove the __initdata marker. The other
> is to correctly mark end of avn_cstates array. The second bug should
> be introduced when merging "22e580d intel_idle: Fixed C6 state on
> Avoton/Rangeley processors" with "eba682a intel_idle: shrink states tables".
> Should I split it into two?
No need. I'm going to push your fixes to Linus shortly.
Thanks!
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
next prev parent reply other threads:[~2014-01-10 13:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-09 7:30 [PATCH 1/2] Revert "intel_idle: mark states tables with __initdata tag" Jiang Liu
2014-01-09 7:30 ` [PATCH 2/2] intel_idle: close avn_cstates array with correct marker Jiang Liu
2014-01-09 13:31 ` Rafael J. Wysocki
2014-01-10 1:59 ` Jiang Liu
2014-01-10 13:32 ` Rafael J. Wysocki [this message]
2014-01-09 13:20 ` [PATCH 1/2] Revert "intel_idle: mark states tables with __initdata tag" Bartlomiej Zolnierkiewicz
2014-01-09 13:38 ` Rafael J. Wysocki
2014-01-10 9:23 ` Bartlomiej Zolnierkiewicz
2014-01-10 1:32 ` Jiang Liu
2014-01-09 13:29 ` Rafael J. Wysocki
2014-01-09 13:22 ` Bartlomiej Zolnierkiewicz
2014-01-10 2:01 ` Jiang Liu
2014-01-10 13:48 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1676949.y75c76bCzK@vostro.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=hpa@linux.intel.com \
--cc=jiang.liu@linux.intel.com \
--cc=len.brown@intel.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®