From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: Jiang Liu <jiang.liu@linux.intel.com>,
" Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
" H. Peter Anvin" <hpa@linux.intel.com>,
Len Brown <len.brown@intel.com>, Len Brown <lenb@kernel.org>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] Revert "intel_idle: mark states tables with __initdata tag"
Date: Thu, 09 Jan 2014 14:38:14 +0100 [thread overview]
Message-ID: <2380177.4Omy8JvF8m@vostro.rjw.lan> (raw)
In-Reply-To: <1987543.MckBKZrloE@amdc1032>
Hi,
On Thursday, January 09, 2014 02:20:22 PM Bartlomiej Zolnierkiewicz wrote:
>
> Hi,
>
> On Thursday, January 09, 2014 03:30:26 PM Jiang Liu wrote:
> > This reverts commit 9d046ccb98085f1d437585f84748c783a04ba240.
> >
> > Commit 9d046ccb98085 marks all state tables with __initdata, but
> > the state table may be accessed when doing CPU online, which then
> > causing system crash as below:
>
> Uh, sorry for that - it most likely got missed since I tested it
> together with intel_idle_cpu_init() removal patches (they are in
> Rafael's PM tree now).
>
> Anyway, better than reverting it altogether would be to fix it by
> backporting the following patch:
>
> http://lkml.org/lkml/2013/12/20/372
>
> Could you please try to solve the issue this way?
No, it's too late for that as far as 3.13 is concerned.
I have the patch above queued up for 3.14, though, so do you think that the
commit being reverted here can be safely re-applied on top of it?
Rafael
next prev parent reply other threads:[~2014-01-09 13:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-09 7:30 Jiang Liu
2014-01-09 7:30 ` [PATCH 2/2] intel_idle: close avn_cstates array with correct marker Jiang Liu
2014-01-09 13:31 ` Rafael J. Wysocki
2014-01-10 1:59 ` Jiang Liu
2014-01-10 13:32 ` Rafael J. Wysocki
2014-01-09 13:20 ` [PATCH 1/2] Revert "intel_idle: mark states tables with __initdata tag" Bartlomiej Zolnierkiewicz
2014-01-09 13:38 ` Rafael J. Wysocki [this message]
2014-01-10 9:23 ` Bartlomiej Zolnierkiewicz
2014-01-10 1:32 ` Jiang Liu
2014-01-09 13:29 ` Rafael J. Wysocki
2014-01-09 13:22 ` Bartlomiej Zolnierkiewicz
2014-01-10 2:01 ` Jiang Liu
2014-01-10 13:48 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2380177.4Omy8JvF8m@vostro.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=b.zolnierkie@samsung.com \
--cc=hpa@linux.intel.com \
--cc=jiang.liu@linux.intel.com \
--cc=len.brown@intel.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®