* [PATCH] qed/qed_mng_tlv: correctly zero out ->min instead of ->hour
@ 2023-03-15 19:46 Daniil Tatianin
2023-03-17 4:20 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Daniil Tatianin @ 2023-03-15 19:46 UTC (permalink / raw)
To: Ariel Elior
Cc: Daniil Tatianin, Manish Chopra, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Sudarsana Reddy Kalluru, netdev,
linux-kernel
This fixes an issue where ->hour would erroneously get zeroed out
instead of ->min because of a bad copy paste.
Found by Linux Verification Center (linuxtesting.org) with the SVACE
static analysis tool.
Fixes: f240b6882211 ("qed: Add support for processing fcoe tlv request.")
Signed-off-by: Daniil Tatianin <d-tatianin@yandex-team.ru>
---
drivers/net/ethernet/qlogic/qed/qed_mng_tlv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/qlogic/qed/qed_mng_tlv.c b/drivers/net/ethernet/qlogic/qed/qed_mng_tlv.c
index 6190adf965bc..f55eed092f25 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_mng_tlv.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_mng_tlv.c
@@ -422,7 +422,7 @@ qed_mfw_get_tlv_time_value(struct qed_mfw_tlv_time *p_time,
if (p_time->hour > 23)
p_time->hour = 0;
if (p_time->min > 59)
- p_time->hour = 0;
+ p_time->min = 0;
if (p_time->msec > 999)
p_time->msec = 0;
if (p_time->usec > 999)
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] qed/qed_mng_tlv: correctly zero out ->min instead of ->hour
2023-03-15 19:46 [PATCH] qed/qed_mng_tlv: correctly zero out ->min instead of ->hour Daniil Tatianin
@ 2023-03-17 4:20 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-03-17 4:20 UTC (permalink / raw)
To: Daniil Tatianin
Cc: aelior, manishc, davem, edumazet, kuba, pabeni,
sudarsana.kalluru, netdev, linux-kernel
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Wed, 15 Mar 2023 22:46:18 +0300 you wrote:
> This fixes an issue where ->hour would erroneously get zeroed out
> instead of ->min because of a bad copy paste.
>
> Found by Linux Verification Center (linuxtesting.org) with the SVACE
> static analysis tool.
>
> Fixes: f240b6882211 ("qed: Add support for processing fcoe tlv request.")
> Signed-off-by: Daniil Tatianin <d-tatianin@yandex-team.ru>
>
> [...]
Here is the summary with links:
- qed/qed_mng_tlv: correctly zero out ->min instead of ->hour
https://git.kernel.org/netdev/net/c/470efd68a465
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-17 4:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-15 19:46 [PATCH] qed/qed_mng_tlv: correctly zero out ->min instead of ->hour Daniil Tatianin
2023-03-17 4:20 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®