From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Joel Fernandes <joelaf@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
Len Brown <lenb@kernel.org>,
Viresh Kumar <viresh.kumar@linaro.org>,
Ingo Molnar <mingo@redhat.com>,
Juri Lelli <juri.lelli@redhat.com>,
Patrick Bellasi <patrick.bellasi@arm.com>,
Chris Redpath <Chris.Redpath@arm.com>,
Steve Muckle <smuckle@google.com>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Morten Ramussen <morten.rasmussen@arm.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Saravana Kannan <skannan@quicinc.com>,
Vikram Mulukutla <markivx@codeaurora.org>,
Rohit Jain <rohit.k.jain@oracle.com>,
Atish Patra <atish.patra@oracle.com>, Josef Bacik <jbacik@fb.com>,
Rik van Riel <riel@redhat.com>,
EAS Dev <eas-dev@lists.linaro.org>
Subject: Re: [PATCH RESEND] cpufreq: schedutil: Use idle_calls counter of the remote CPU
Date: Wed, 20 Dec 2017 15:45:13 +0100 [thread overview]
Message-ID: <1680359.YAEeiLAcPD@aspire.rjw.lan> (raw)
In-Reply-To: <CAJWu+orWw6TFy165d1a=Fk4AfGNfSvcZ9SGj5KKD6V4YSqK50g@mail.gmail.com>
On Tuesday, December 19, 2017 8:32:09 PM CET Joel Fernandes wrote:
> On Tue, Dec 19, 2017 at 10:48 AM, Peter Zijlstra <peterz@infradead.org> wrote:
> > On Tue, Dec 19, 2017 at 09:47:12AM -0800, Joel Fernandes wrote:
> >> Since the recent remote cpufreq callback work, its possible that a cpufreq
> >> update is triggered from a remote CPU. For single policies however, the current
> >> code uses the local CPU when trying to determine if the remote sg_cpu entered
> >> idle or is busy. This is incorrect. To remedy this, compare with the nohz tick
> >> idle_calls counter of the remote CPU.
> >>
> >> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
> >> Signed-off-by: Joel Fernandes <joelaf@google.com>
> >
> > Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
>
> Sweet!
OK, so any chance to get a Fixes: tag for the patch?
Thanks,
Rafael
next prev parent reply other threads:[~2017-12-20 14:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-19 17:47 Joel Fernandes
2017-12-19 18:48 ` Peter Zijlstra
2017-12-19 19:32 ` Joel Fernandes
2017-12-20 14:45 ` Rafael J. Wysocki [this message]
2017-12-20 17:44 ` Joel Fernandes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1680359.YAEeiLAcPD@aspire.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=Chris.Redpath@arm.com \
--cc=atish.patra@oracle.com \
--cc=dietmar.eggemann@arm.com \
--cc=eas-dev@lists.linaro.org \
--cc=fweisbec@gmail.com \
--cc=jbacik@fb.com \
--cc=joelaf@google.com \
--cc=juri.lelli@redhat.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markivx@codeaurora.org \
--cc=mingo@redhat.com \
--cc=morten.rasmussen@arm.com \
--cc=patrick.bellasi@arm.com \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
--cc=rohit.k.jain@oracle.com \
--cc=skannan@quicinc.com \
--cc=smuckle@google.com \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome