From: Rob Herring <robh@kernel.org>
To: Jaewon Kim <jaewon02.kim@samsung.com>
Cc: linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
Mark Brown <broonie@kernel.org>,
Chanho Park <chanho61.park@samsung.com>,
Rob Herring <robh+dt@kernel.org>,
linux-kernel@vger.kernel.org, Andi Shyti <andi@etezian.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
linux-spi@vger.kernel.org
Subject: Re: [PATCH 2/3] spi: dt-bindings: samsung: add samsung,spi-polling property
Date: Tue, 04 Apr 2023 07:36:32 -0500 [thread overview]
Message-ID: <168061169110.3708482.17770599727715267512.robh@kernel.org> (raw)
In-Reply-To: <20230404060011.108561-3-jaewon02.kim@samsung.com>
On Tue, 04 Apr 2023 15:00:10 +0900, Jaewon Kim wrote:
> This patch adds "samsung,spi-polling" property.
> It is method to check data trans by polling when DMA is not used.
>
> Signed-off-by: Jaewon Kim <jaewon02.kim@samsung.com>
> ---
> Documentation/devicetree/bindings/spi/samsung,spi.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/spi/samsung,spi.yaml: properties:samsung,spi-polling: 'oneOf' conditional failed, one must be fixed:
Additional properties are not allowed ('default' was unexpected)
hint: A vendor boolean property can use "type: boolean"
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/spi/samsung,spi.yaml: properties:samsung,spi-polling: 'oneOf' conditional failed, one must be fixed:
'enum' is a required property
'const' is a required property
hint: A vendor string property with exact values has an implicit type
from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
Additional properties are not allowed ('default', 'type' were unexpected)
hint: A vendor string property with exact values has an implicit type
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/spi/samsung,spi.yaml: properties:samsung,spi-polling: 'oneOf' conditional failed, one must be fixed:
'$ref' is a required property
'allOf' is a required property
hint: A vendor property needs a $ref to types.yaml
from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
hint: Vendor specific properties must have a type and description unless they have a defined, common suffix.
from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
./Documentation/devicetree/bindings/soc/samsung/exynos-usi.yaml: Error in referenced schema matching $id: http://devicetree.org/schemas/spi/samsung,spi.yaml
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230404060011.108561-3-jaewon02.kim@samsung.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2023-04-04 12:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230404061409epcas2p2e97fff5459b405db0d5a206e2ad38f82@epcas2p2.samsung.com>
2023-04-04 6:00 ` [PATCH 0/3] spi: s3c64xx: improve SPI polling mode Jaewon Kim
[not found] ` <CGME20230404061409epcas2p15750d5844aa8d3655d1bfd094fac14a9@epcas2p1.samsung.com>
2023-04-04 6:00 ` [PATCH 1/3] spi: s3c64xx: support spi polling mode using devicetree Jaewon Kim
2023-04-04 10:54 ` Mark Brown
2023-04-04 11:17 ` Jaewon Kim
2023-04-04 11:41 ` Mark Brown
2023-04-04 12:22 ` Jaewon Kim
2023-04-04 12:41 ` Mark Brown
2023-04-05 5:42 ` Krzysztof Kozlowski
2023-04-05 11:42 ` Jaewon Kim
[not found] ` <CGME20230404061409epcas2p36402f7a84406ba9d831dcff0ddd994e9@epcas2p3.samsung.com>
2023-04-04 6:00 ` [PATCH 2/3] spi: dt-bindings: samsung: add samsung,spi-polling property Jaewon Kim
2023-04-04 12:36 ` Rob Herring [this message]
[not found] ` <CGME20230404061409epcas2p2b12a9cac014907e3930795cb67cb6040@epcas2p2.samsung.com>
2023-04-04 6:00 ` [PATCH 3/3] spi: s3c64xx: support interrupt based pio mode Jaewon Kim
2023-04-04 12:58 ` Mark Brown
2023-04-04 13:15 ` Jaewon Kim
2023-04-04 13:33 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=168061169110.3708482.17770599727715267512.robh@kernel.org \
--to=robh@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=andi@etezian.org \
--cc=broonie@kernel.org \
--cc=chanho61.park@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=jaewon02.kim@samsung.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®