From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Jaewon Kim <jaewon02.kim@samsung.com>,
Andi Shyti <andi@etezian.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>
Cc: linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Chanho Park <chanho61.park@samsung.com>
Subject: Re: [PATCH 1/3] spi: s3c64xx: support spi polling mode using devicetree
Date: Wed, 5 Apr 2023 07:42:53 +0200 [thread overview]
Message-ID: <c1163417-16ea-63ee-5b8d-47cdff8069b1@linaro.org> (raw)
In-Reply-To: <20230404060011.108561-2-jaewon02.kim@samsung.com>
On 04/04/2023 08:00, Jaewon Kim wrote:
> This patch adds new 'samsung,spi-polling' property to support polling mode.
Do not use "This commit/patch", but imperative mood. See:
https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95
Also, binding should be before its usage.
> In some environments, polling mode is required even if DMA is supported.
Why? What are these environments? You need to explain all this in commit
msg.
> Changed it to support not only with quick but also optinally with
typo: optionally
> devicetree.
>
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-04-05 5:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230404061409epcas2p2e97fff5459b405db0d5a206e2ad38f82@epcas2p2.samsung.com>
2023-04-04 6:00 ` [PATCH 0/3] spi: s3c64xx: improve SPI polling mode Jaewon Kim
[not found] ` <CGME20230404061409epcas2p15750d5844aa8d3655d1bfd094fac14a9@epcas2p1.samsung.com>
2023-04-04 6:00 ` [PATCH 1/3] spi: s3c64xx: support spi polling mode using devicetree Jaewon Kim
2023-04-04 10:54 ` Mark Brown
2023-04-04 11:17 ` Jaewon Kim
2023-04-04 11:41 ` Mark Brown
2023-04-04 12:22 ` Jaewon Kim
2023-04-04 12:41 ` Mark Brown
2023-04-05 5:42 ` Krzysztof Kozlowski [this message]
2023-04-05 11:42 ` Jaewon Kim
[not found] ` <CGME20230404061409epcas2p36402f7a84406ba9d831dcff0ddd994e9@epcas2p3.samsung.com>
2023-04-04 6:00 ` [PATCH 2/3] spi: dt-bindings: samsung: add samsung,spi-polling property Jaewon Kim
2023-04-04 12:36 ` Rob Herring
[not found] ` <CGME20230404061409epcas2p2b12a9cac014907e3930795cb67cb6040@epcas2p2.samsung.com>
2023-04-04 6:00 ` [PATCH 3/3] spi: s3c64xx: support interrupt based pio mode Jaewon Kim
2023-04-04 12:58 ` Mark Brown
2023-04-04 13:15 ` Jaewon Kim
2023-04-04 13:33 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c1163417-16ea-63ee-5b8d-47cdff8069b1@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=andi@etezian.org \
--cc=broonie@kernel.org \
--cc=chanho61.park@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=jaewon02.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®